Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rectpacking does not preserve row dominant elements #1077

Open
soerendomroes opened this issue Oct 7, 2024 · 0 comments
Open

Rectpacking does not preserve row dominant elements #1077

soerendomroes opened this issue Oct 7, 2024 · 0 comments
Labels
alg-rectpacking Affects the ELK RectPacking algorithm. bug Erroneous behaviour.

Comments

@soerendomroes
Copy link
Contributor

Describe the bug
See here.
We see that initially rectpacking makes correct rows (see placement of n5).
However, during compaction it seems that n1 and n2 steal n3 and n4 and increase the height of the row (somehow).
Hence, n5 can fit all nodes to n10 on top of it, potentially making it harder to visually spot the row.
This does also not seem to be an optimization for the last row as seen at n11.

Expected behavior
I would expect a row with n1 and n2, then a row with n3 and n4 and n5, n6, and n7 stacked next to it and the other nodes in a new row.

Screenshots
What I get:
image

What I want:
image

ELK Version
All versions that include rectpacking.

@soerendomroes soerendomroes added bug Erroneous behaviour. alg-rectpacking Affects the ELK RectPacking algorithm. labels Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alg-rectpacking Affects the ELK RectPacking algorithm. bug Erroneous behaviour.
Projects
None yet
Development

No branches or pull requests

1 participant