Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eCAL::core: make publisher ID available in callbacks #1722

Open
2 of 3 tasks
Tracked by #1237
KerstinKeller opened this issue Aug 26, 2024 · 0 comments
Open
2 of 3 tasks
Tracked by #1237

eCAL::core: make publisher ID available in callbacks #1722

KerstinKeller opened this issue Aug 26, 2024 · 0 comments

Comments

@KerstinKeller
Copy link
Contributor

KerstinKeller commented Aug 26, 2024

Idea

For Subscribers, we want to make the publisher ID available in callbacks.
This has several benefits, especially when one Subscriber is connected to multiple publisher:

  • Users can clearly distiguish where the data originates from
  • Subscribers can retrieve Datatype information within the callback
    • They can detect datatype missmatches
    • In case of dynamic subscribers, they can have mutliple ways to do introspection, e.g. one per (distinct) publisher

Implementation:

Information needs to be available in callbacks, thus it needs to be forwarded between registration of a publisher and the respective callback. Not all layers transmit the information, but they do not need to.

  • Subscribers need their callback Signature to contain STopicID.
  • Implement tests that clearly check callbacks contain the correct sender ID.
  • Adapt dynamic subscribers to obtain their SDatatypeInformation through the callback.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant