Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error messages for connection domain blacklists are confusing #681

Open
w4tsn opened this issue May 13, 2020 · 1 comment
Open

Error messages for connection domain blacklists are confusing #681

w4tsn opened this issue May 13, 2020 · 1 comment

Comments

@w4tsn
Copy link
Contributor

w4tsn commented May 13, 2020

When creating an mqtt-connector:

In case the domain of e.g. an mqtt service for a connector is not only publicly available but also via an alias within a docker network directly reachable through the local network the connector will not be created and an error will be thrown that the domain mqtt.public-and-valid.org is blacklisted. This happens, because the domain is internally translated to local addresses, which is indeed an undesired target from the point of view of the implementation. The problem however is, that the error message does not provide any hint about this being the case and instead complains that the valid domain is blacklisted which is not the case.

The error messages in this case need to give more details about what is happening. This has to become more agnostic to the underlying networking behavior.

@dguggemos
Copy link
Contributor

That's a good point, we should provide more details why the url was blacklisted e.g. the host resolved to a local address etc. We plan to enhance the url validation check anyways, so we can improve the error messages in one go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants