Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add best_fulltext_link method #26

Open
bmckinney opened this issue Apr 8, 2017 · 2 comments
Open

Add best_fulltext_link method #26

bmckinney opened this issue Apr 8, 2017 · 2 comments
Assignees

Comments

@bmckinney
Copy link
Contributor

see: https://github.com/ebsco/ebsco-discovery-service-api-gem/blob/4f13127cfc037c0f2271c5a59987a2256fabb075/lib/ebsco-discovery-service-api.rb#L578

make configurable so that users can specify an order of link types to fall back on

example: best_fulltext_link: ['html', 'pdf', 'epub', 'custom']

@bmckinney bmckinney self-assigned this Apr 8, 2017
@sandbergja
Copy link
Contributor

sandbergja commented Apr 29, 2020

This would be very helpful for us!

Right now, I am iterating through an article's eds_fulltext_links until I find one where

  1. the link's [:url] != 'detail', and
  2. the link's [:type] != 'cataloglink'

Just because those are the two that have been problematic for us in the past. But there could be other entries in that eds_fulltext_links array that are also problematic, and we just haven't discovered the problem yet. Having a somewhat opinionated best_fulltext_link method that protects us from those eds_fulltext_links that aren't actually fulltext links would be very helpful.

@sandbergja
Copy link
Contributor

Another note: we are de-prioritizing Full Text Finder links (link[:label] != 'Full Text Finder') when there is another link available, with the hope that this leads to fewer steps for patrons before they actually get to the full text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants