-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't get 8.1.1 to work #53
Comments
Hello @abbydrury I has been created another release could try to version 8.1.2 Also you can clone from a specific branch. Thank you. |
Two things:
The errors are
Are you also seeing these errors when you test? |
Hello @abbydrury Please, could you send a email with yours specific environments? Send a email to me kanthony at ebsco dot com. Thank you. |
I guess I'm not sure what you're asking for. We're running Drupal 8.9.19. My development environment is Mac OS X 10.15.7, using Lando's (version 3.3.2) Pantheon recipe for Drupal 8 - Lando is a tool that helps manage Docker-based development environments, and was Pantheon's tool of choice for development when we created this site. We manage Drupal packages with Composer for cross-environment portability. I don't know why the environment would matter in this case though. I haven't looked deeply at this, but |
Something changes on Drupal 8.9.19 core. |
Hello, The version 8 is okay now from my end Could you try this way? git clone --branch edsapi-drupal8-release [email protected]:ebsco/edsapi-drupal-plugin.git We still have a warning but i'm check, probably it is something from drupal core and not the app itself. Thank you. |
I can't get this to work, even using the "standard" install option to create a brand-new instance of Drupal 8.9.19 and cloning the EBSCO module with With the same configuration values in version 0.2 of the module, we do get the correct results even with our custom code to tweak the display surrounding it (the ESBCO results are the center "Library materials" column): I do see this error in dblog. It does look like it's from core, and it looks like the value it's having trouble with is "autocomplete". It might be coincidental, but that is one of the API fields - is it possible that there's a string object somewhere that should be part of an array instead?
Or, are there additional or different configuration expectations/values in this newer version of the module? |
Yes, I cleared the Drupal cache and the browser cache. |
Hi, I’m working on the same codebase as @abbydrury . 1. Deprecated function callYou still have not fixed the deprecated call to diff --git a/ebsco.module b/ebsco.module
index 3a6cb52..ebd727a 100755
--- a/ebsco.module
+++ b/ebsco.module
@@ -1741,10 +1741,9 @@ function auto_link($string)
{
$linkedString = preg_replace_callback(
"/\b(https?):\/\/([-A-Z0-9+&@#\/%?=~_|!:,.;]*[-A-Z0-9+&@#\/%=~_|]*)\b/i",
- create_function(
- '$matches',
- 'return "<a href=\'".($matches[0])."\'>".($matches[0])."</a>";'
- ),
+ function ($matches) {
+ return "<a href='".($matches[0])."'>".($matches[0])."</a>";
+ },
$string
); 2. Invalid argument valueAbby did some more digging and found that the 3. Code for displaying errorsIn chasing that, I noticed the \Drupal::logger('my_module')->error($message); 4. New warning when processing resultsWhen I try to render the results, the module logs this for each entry in the result set: Changing line 771 to this removes the problem: if ($record->IllustrationInfo && $record->IllustrationInfo->Images) { |
Two more updates:
|
We're running Drupal 8.9.19 and are attempting to upgrade from v0.2 of this module to v8.1.1 of this module. When I execute a search in v8.1.1 that previously worked in v0.2, the search fails and I get a pile of errors (I think 36 for every query). The first one is this:
Here is the summary list of them all:
Please help!
The text was updated successfully, but these errors were encountered: