Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary Integer cast causes error during ARXML export #786

Closed
ChristianSteffens opened this issue May 6, 2024 · 2 comments
Closed
Assignees
Labels

Comments

@ChristianSteffens
Copy link

I might be mistaken, but isn't this integer conversion unnecessary? It causes an error during ARXML export, considering that the signal values are already stored as integers.

for value in sorted(signal.values, key=lambda x: int(x, 0)):

canmatrix\formats\arxml.py", line 800, in <lambda>
    for value in sorted(signal.values, key=lambda x: int(x, 0)):
                                                     ^^^^^^^^^
TypeError: int() can't convert non-string with explicit base
@ebroecker ebroecker self-assigned this Jun 19, 2024
ebroecker pushed a commit that referenced this issue Jun 27, 2024
@ebroecker
Copy link
Owner

Hi @ChristianSteffens

after a quick view to the code it seems you are right.

ebroecker added a commit that referenced this issue Jul 15, 2024
Co-authored-by: Eduard Bröcker <[email protected]>
@ebroecker
Copy link
Owner

should be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants