Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translations #17

Open
ebrahimebrahim opened this issue Sep 21, 2020 · 3 comments
Open

Add translations #17

ebrahimebrahim opened this issue Sep 21, 2020 · 3 comments
Labels
enhancement New feature or request optional Not necessary before completion of the project, but might be nice

Comments

@ebrahimebrahim
Copy link
Owner

It would be fun to add Arabic and Chinese

Strings.gd would have to be told about the labels on all the buttons and in all the panels
UI elements would need to be given scripts that initialize their labels by querying Strings.gd

@ebrahimebrahim ebrahimebrahim added enhancement New feature or request optional Not necessary before completion of the project, but might be nice labels Sep 21, 2020
@ebrahimebrahim
Copy link
Owner Author

for later projects we probably want to import a table

kind of like described here: https://docs.godotengine.org/en/latest/getting_started/workflow/assets/importing_translations.html#doc-importing-translations

but for this project I'm sticking with hardcoding strings into Strings.gd

@ebrahimebrahim
Copy link
Owner Author

right now everything is ready to be translated in Strings.gd, with the exception of the help panel text (which we may or may not bother translating)

yusufmte added a commit that referenced this issue Sep 29, 2020
The translations are in Strings.gd, but they don't work yet presumably because Avara doesn't include arabic characters. Likely a signal will have to be sent when the language is changed which then changes the font/the themes of things.
@yusufmte
Copy link
Collaborator

We tried arabi with a font that seemed compatible, letters did not connect and were displayed left-right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request optional Not necessary before completion of the project, but might be nice
Projects
None yet
Development

No branches or pull requests

2 participants