From 5b31709be4539cd9a3e1243a2384b2519286a440 Mon Sep 17 00:00:00 2001 From: Brian Eaton Date: Fri, 16 Jun 2023 15:44:11 -0400 Subject: [PATCH 1/2] extend workaround for Intel optimization bug to v19 compiler (#219) Thanks to Brian Eaton at NCAR (@brian-eaton) --- rrtmgp-kernels/mo_gas_optics_rrtmgp_kernels.F90 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rrtmgp-kernels/mo_gas_optics_rrtmgp_kernels.F90 b/rrtmgp-kernels/mo_gas_optics_rrtmgp_kernels.F90 index 5dd61a297..fc6fceff3 100644 --- a/rrtmgp-kernels/mo_gas_optics_rrtmgp_kernels.F90 +++ b/rrtmgp-kernels/mo_gas_optics_rrtmgp_kernels.F90 @@ -72,7 +72,7 @@ subroutine interpolation( & !! use lower (or upper) atmosphere tables integer, dimension(2, ncol,nlay,nflav), intent(out) :: jeta !! Index for binary species interpolation -#if !defined(__INTEL_LLVM_COMPILER) && __INTEL_COMPILER >= 2021 +#if !defined(__INTEL_LLVM_COMPILER) && __INTEL_COMPILER >= 1910 ! A performance-hitting workaround for the vectorization problem reported in ! https://github.com/earth-system-radiation/rte-rrtmgp/issues/159 ! The known affected compilers are Intel Fortran Compiler Classic From 1cb0a4eac3042772e3f38c2e59177dae692f79f1 Mon Sep 17 00:00:00 2001 From: Chiel van Heerwaarden Date: Wed, 21 Jun 2023 17:01:12 +0200 Subject: [PATCH 2/2] Make rfmip fail if the reference data is empty or corrupted. --- examples/rfmip-clear-sky/compare-to-reference.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/examples/rfmip-clear-sky/compare-to-reference.py b/examples/rfmip-clear-sky/compare-to-reference.py index de6cc05bf..3f7b0c629 100755 --- a/examples/rfmip-clear-sky/compare-to-reference.py +++ b/examples/rfmip-clear-sky/compare-to-reference.py @@ -37,6 +37,9 @@ failed = False for v in variables: + if np.any(np.isnan(ref.variables[v].values)): + raise Exception( + v + ": some ref values are missing. Now that is strange.") if np.all(np.isnan(tst.variables[v].values)): raise Exception( v + ": all test values are missing. Were the tests run?")