Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin adds “a[data-mtli […]” underneath files on custom post type #35

Open
x06designs opened this issue Jun 13, 2022 · 5 comments

Comments

@x06designs
Copy link

I installed MimeTypes Link Icons on one of my websites. Unfortunately there seems to be a bug. After adding two files to a custom post type, there is a line of text added “a[data-mtli~=”mtli_filesize1,37MB”]:after {content:” (1,37 MB)”}a[data-mtli~=”mtli_filesize1,73MB”]:after {content:” (1,73 MB)”}”. How can I get rid of this? The text doesn't appear on all pages with files - therefore, I unfortunately don't know what is responsible for the error to appear.

I am using the latest version of WordPress with the Jupiter X theme and Elementor.

@eagerterrier
Copy link
Owner

do you have link? I can't replicate

@x06designs
Copy link
Author

I fixed the bug in my pending pull request. After updating to your newest version, the error reappeared. I can't provide a link, as it's a closed members website, but I can provide a screenshot:
image

@eagerterrier
Copy link
Owner

hey @x06designs - thanks for this. Couldn't take all the changes, so cherry picked and gave you credit in the credit/contributors section.

The echo line looked weird, so I didn't change it, thinking earlier changes would have worked on this issue (such as data-mtli rather than rel)

however, if that's not the case, then I've put in the echo line into latest version of plugin as I tested it on my live WP site and it seems fine. Odd that it didn't work before. ¯(°_o)/¯

Anyway, v 3.2.18 has just gone out. Let me know if that fixes the issue.

@x06designs
Copy link
Author

Unfortunately I still see the weird addition after the files:
a[data-mtli~="mtli_filesize1,37MB"]:after {content:" (1,37 MB)"}a[data-mtli~="mtli_filesize1,73MB"]:after {content:" (1,73 MB)"} a[data-mtli~="mtli_filesize1,37MB"]:after {content:" (1,37 MB)"}a[data-mtli~="mtli_filesize1,73MB"]:after {content:" (1,73 MB)"} a[data-mtli~="mtli_filesize1,37MB"]:after {content:" (1,37 MB)"}a[data-mtli~="mtli_filesize1,73MB"]:after {content:" (1,73 MB)"} a[data-mtli~="mtli_filesize1,37MB"]:after {content:" (1,37 MB)"}a[data-mtli~="mtli_filesize1,73MB"]:after {content:" (1,73 MB)"} a[data-mtli~="mtli_filesize1,37MB"]:after {content:" (1,37 MB)"}a[data-mtli~="mtli_filesize1,73MB"]:after {content:" (1,73 MB)"}
(same as in my previous screenshot).

I am running the latest version (3.2.19) and the website uses the Elementor page builder. The console doesn't show any errors, so I have no clue why this data-mtli texts appear.

@x06designs
Copy link
Author

x06designs commented Apr 10, 2024

hey @x06designs - thanks for this. Couldn't take all the changes, so cherry picked and gave you credit in the credit/contributors section.

The echo line looked weird, so I didn't change it, thinking earlier changes would have worked on this issue (such as data-mtli rather than rel)

however, if that's not the case, then I've put in the echo line into latest version of plugin as I tested it on my live WP site and it seems fine. Odd that it didn't work before. ¯(°_o)/¯

Anyway, v 3.2.18 has just gone out. Let me know if that fixes the issue.

I found the problem. All of my posts, that had a link to a file in the content area, had some artifacts (it looked like a video icon in the WYSIWYG-editor). After deleting it the whole data-mtli part is gone. The artifacts must've been automatically added from a previous version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants