-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Penman-Monteith forcing (and the struggles of ESMValTool) #397
Comments
For an "eWaterCycle v3.0" I would propose to make esmvalcore optional, and make it not load on In the future it might be possible to directly use xarray to get ecmwf data, see https://github.com/bopen/xarray-ecmwf. This could make for a much more lightweight default forcing generator. |
good one to discuss in person Thursday, while I support stopping with trying to build a generic Penman-Monteith forcing, I do not support the notion of stopping with ESMValTool as integral part of eWaterCycle. Let's discuss in person and report back here on outcomes |
I recognize many of your frustrations, and I could agree with making esmvalcore optional (but not abandoning it).
Lot's of climate studies also include era5 as a reference. A properly cmorized version of era5 would be very welcome. Whether that should be our concern is up for debate. |
I also recognize the struggles (didn't get a simple ERA5 CMIP comparison to run yesterday...) I would like to postpone this choice after we know if big Horizon proposal just submitted gets accepted. If it does, we are building eWaterCycle on top of the DestinE Service Platform with it's own access to ESA data lake (which includes CMIP and ECMWF data). If we don't get that, we can continue this discussion on the V3 requirements |
To clarify: I did not want to advocate for abandoning esmvaltool, but mostly making it
This would be a pretty major project, as one of the main things that are lacking now is the small overlap between the MIP table variables and the ERA5 CMORized variables. |
Note that ESMValTool supports on-the-fly cmorization. CMORizers can be added per-variable, see https://github.com/ESMValGroup/ESMValCore/blob/main/esmvalcore/cmor/_fixes/native6/era5.py and https://docs.esmvaltool.org/en/latest/input.html#datasets-in-native-format |
Additional issue encountered by Rolf here. ESMValTool uses the center of the time bounds (i.e. noon) for daily data. This will conflict with other daily data loaded with e.g. pandas and xarray. It's also not really following the cf-conventions. According to those |
In PR #393 I attempted to add a generic forcing that would provide users with the meteo data required for the Penman-Monteith equation. I.e., air temperature, net radiation, vapor pressure deficit, wind speed.
However, I encountered a few issues:
Eday
andday
because this is impossible to find in ESMValTool documentation, CMOR documentation, CMIP documentation.Due to the issues piling up, we decided to put this on halt and finish up the PR without PM.
Here is how far I got:
https://gist.github.com/BSchilperoort/254fb3c5a54155b72e08861f40cb0e14
Of course this is a frustrating experience for myself, but I think this also touches on a more general problem: ESMValTool is built for evaluating climate model output. We're trying to use it for hydrological model input. This will clash in many ways, especially with ERA5 not fitting in CMIP properly.
While I do think that there is no alternative for ESMValTool when trying to get climate model data forcing data, I think that it might be better to give up on ERA5 + ESMValTool as it makes things a lot more complicated than it needs to be.
The text was updated successfully, but these errors were encountered: