-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop ESMValTool dependency? #337
Comments
Install esmvalcore still cumbersome due to cartopy dependency (non installable through pip) |
In #365 you can now build a ESMvalTool recipe optionally with your local diagnostic script. So you no longer need to modify the ESMValTool repo to add a recipe. The classic models (Marrmot, hype, etc.) still use diagnostic scripts that comes from the ESMValTool Python package so we still depend on that package. We could copy the diagnostic script to the eWaterCycle plugin, then we could have ESMValCore as dep and drop ESMValTool as dep. |
On further inspection at
esmvaltool.diag_scripts.shared module.
I do not see a way to not depend on ESMValTool package. So this issue can not be implemented. |
Currently,
ewatercycle
depends onesmvaltool-python
. This is quite a heavy package as it installs all dependencies for all (python) recipes included with esmvaltool. Also, we need to make PRs to ESMValTool to update hydrology recipes.One possibility would be to move the hydrology recipes (and diagnostic scripts) to eWaterCycle (or its plugins, see #335), and only rely on ESMValCore to execute them. The downside of this would be that there is no longer a central place where people can find all the hydrology recipes. But to be FAIR, we believe there shouldn't be that many...
Another alternative could be to spin off ESMValTool-Hydrology into its own small package.
The text was updated successfully, but these errors were encountered: