Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lisflood: Refactor _create_lisflood_config to accept other formats than .nc for MaskMap #123

Closed
SarahAlidoost opened this issue Jun 22, 2021 · 2 comments · Fixed by #134
Closed

Comments

@SarahAlidoost
Copy link
Contributor

Currently, in lisflood module, in _create_lisflood_config, it is assumed that MaskMap has .nc format. But MAskMap can have other formats like .map. This line needs a refactoring.

@sverhoeven
Copy link
Member

Yep, if we want to use https://github.com/ec-jrc/lisflood-usecases as example parameter set we need support for mask.map , see eWaterCycle/ewatercycle-lisflood#12

@sverhoeven sverhoeven added this to the Tech paper milestone Jun 25, 2021
@SarahAlidoost
Copy link
Contributor Author

As mentioned in eWaterCycle/ewatercycle-lisflood#12, we cannot use other use-cases for now. However, I think the lisflood class can be refactored to avoid .rstrip('.nc').

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants