Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netcdfinput of Wflow model too truncated #7

Open
sverhoeven opened this issue Jul 7, 2021 · 2 comments
Open

netcdfinput of Wflow model too truncated #7

sverhoeven opened this issue Jul 7, 2021 · 2 comments

Comments

@sverhoeven
Copy link
Member

On https://github.com/eWaterCycle/ewatercycle/blob/29d3aed18fb39b3bedb41bac2fd8e9c7277e31be/ewatercycle/models/wflow.py#L59
Path(forcing.netcdfinput).name is used. Some wflow examples use inmaps/inmaps.nc, These examples will not be able to run by ewatercycle.models.Wflow class.
As only storing the name (inmaps.nc) will cause the model to not find the file.

Can the .name be replaced with something that works when inmaps.nc is in a subdirectory of the parameter set?
@sverhoeven sverhoeven mentioned this issue Jul 7, 2021
Merged
@Peter9192
Copy link

something like relative_to(...)?

@sverhoeven sverhoeven changed the title netcdfinput of Wflow mode too truncated netcdfinput of Wflow model too truncated Jul 7, 2021
@SarahAlidoost
Copy link

There should be a folder inmaps according to wflow documentation .

@BSchilperoort BSchilperoort transferred this issue from eWaterCycle/ewatercycle Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sverhoeven @Peter9192 @SarahAlidoost