Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Parameter set object to store Marrmot parameters #5

Open
sverhoeven opened this issue Jun 27, 2022 · 0 comments
Open

Use Parameter set object to store Marrmot parameters #5

sverhoeven opened this issue Jun 27, 2022 · 0 comments

Comments

@sverhoeven
Copy link
Member

Now you have to do

model = ewatercycle.models.MarrmotM14(version="2020.11", forcing=forcing_validation)
cfg_file, cfg_dir = model.setup(
    maximum_soil_moisture_storage=parameters[0],
    threshold_flow_generation_evap_change=parameters[1],
    leakage_saturated_zone_flow_coefficient=parameters[2],
    zero_deficit_base_flow_speed=parameters[3],
    baseflow_coefficient=parameters[4],
    gamma_distribution_chi_parameter=parameters[5],
    gamma_distribution_phi_parameter=parameters[6],
    initial_upper_zone_storage=0.9*parameters[0],
    initial_saturated_zone_storage=0.9*parameters[0],
)

it would be nice to do

parameter_set = ewatercycle.parameter_sets.get_parameter_set("marrmot14-rhine")
model = ewatercycle.models.MarrmotM14(version="2020.11", forcing=forcing_validation, parameter_set=parameter_set)
cfg_file, cfg_dir = model.setup()
@BSchilperoort BSchilperoort transferred this issue from eWaterCycle/ewatercycle Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant