Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lisflood.finalize() not working #5

Open
Peter9192 opened this issue Sep 28, 2021 · 2 comments
Open

Lisflood.finalize() not working #5

Peter9192 opened this issue Sep 28, 2021 · 2 comments
Assignees
@sverhoeven

Comments

@Peter9192
Copy link

As a temporary workaround, we could overwrite the method to not call bmi.finalize, but only destroy the container.
sverhoeven referenced this issue in eWaterCycle/ewatercycle Sep 29, 2021
@sverhoeven
Dont call finalize() on Lisflood.bmi when Lisflood.finalize() is call…
af69821 
…ed. Only perform container clean up

Refs #257
@sverhoeven sverhoeven mentioned this issue Sep 29, 2021
Merged
@sverhoeven
Copy link
Member

Created eWaterCycle/lisflood-code#1

sverhoeven referenced this issue in eWaterCycle/ewatercycle Sep 30, 2021
@sverhoeven
Dont call finalize() on Lisflood.bmi when Lisflood.finalize() is call… (
25623c6 
#264)

* Dont call finalize() on Lisflood.bmi when Lisflood.finalize() is called. Only perform container clean up

Refs #257

* Use finalize in example
sverhoeven referenced this issue in eWaterCycle/ewatercycle Oct 20, 2021
@sverhoeven
Run Lisflood notebook on SRC instead of Cartesius (#265)
39f0306 
* Dont call finalize() on Lisflood.bmi when Lisflood.finalize() is called. Only perform container clean up

Refs #257

* Use finalize in example

* Changes paths so lisflood example notebook works on https://github.com/eWaterCycle/infra

* Replace Cartesius with SRC

* Replace // with / in path to mask
@SarahAlidoost
Copy link

comparison related issue https://github.com/eWaterCycle/era5-comparison/issues/153

@BSchilperoort BSchilperoort transferred this issue from eWaterCycle/ewatercycle Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sverhoeven sverhoeven

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sverhoeven @Peter9192 @SarahAlidoost