Use public use case in lisflood notebook #12
Comments
sverhoeven
referenced
this issue
in eWaterCycle/ewatercycle
Jun 29, 2021
They should be part fix for #124
|
Our lisflood version isnot compatible with the existing lisflood use cases . Also, there is no other public parameters. One way to fix this issue is to create a new use case based on the private parameter set. However, there are some considerations:
|
|
I see the https://github.com/ec-jrc/lisflood-usecases repo made some changes last year to make it work with lisflood v3.0.0 . Could we try to find an older commit that does work with our Docker image? |
sverhoeven
referenced
this issue
in eWaterCycle/ewatercycle
Jul 2, 2021
* initial idea for parameterset catalogue * Refactor catalogue into parameter_sets module * Added some tests * Use the fixture * More tests * Even more tests * Make target_model optional * More todos * less todos * Implemented download_example_parameter_sets() + other bits and pieces * formatting * dont write ewatercycle_config to yaml output * write to previous config; add todo's * Refactor download example parameter sets * Config no longer has `.` in keys, removed dead code/test * Added CFG.save_to_file() * Move example parameter set to own files * Format with black * Added docstrings + made ParameterSet public because it is used in api notebook * Added tests * Formatting * Replace model specific parameter set with generic one * Added notebook for download_example_parameter_sets() * Moved MaskMap from parameter set to setup Fixes #121 * Added ParameterSet.supported_model_versions + AbstractModel._check_parameter_set() Needed a lot of refactoring to please mypy and to have all info together for _check_parameter_set() * Replace SubVersionCopier with get_parameter_set() * Replace `Path.is_relative_to()` with Py37 compatible implementation * Correct sphinx links * Remove unused imports They should be part fix for #124 * Use Lisflood.setup{MaskMap) in notebook * example_parameter_sets() return a dict instead of iterator * Fallback to default value when key is missing in config * Make MarrmotM14 a non-generic class * Flatten test hierarchy * Correct nesting * Raise exceptions in available_parameter_sets and return tuple * Update ewatercycle/models/abstract.py Co-authored-by: Peter Kalverla <[email protected]> * Check model.version against model.available_versions * List class var before object vars * Remove duplicate bmi in docs * Fix tests * Update ewatercycle/models/abstract.py Co-authored-by: Peter Kalverla <[email protected]> * Replace id with name * Add skip_existing arg to download * Revert "Fallback to default value when key is missing in config" This reverts commit f776fce. * Fix test * Fix mypy warning Co-authored-by: Stefan Verhoeven <[email protected]> Co-authored-by: Stefan Verhoeven <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The https://github.com/eWaterCycle/ewatercycle/blob/master/examples/lisflood.ipynb uses a private parameter set. This makes it impossible for other users to run the notebook. Can we change the notebook to use Use case 1: Fraser River, British Columbia, Canada?
The text was updated successfully, but these errors were encountered: