Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite lisflood model tests #1

Open
sverhoeven opened this issue Sep 4, 2023 · 2 comments
Open

Rewrite lisflood model tests #1

sverhoeven opened this issue Sep 4, 2023 · 2 comments

Comments

@sverhoeven
Copy link
Member

The download of parameter set (https://github.com/ec-jrc/lisflood-usecases/archive/refs/heads/master.zip) can take a long time (> 4 minutes) as it downloads over 500Mb and is throttled. We should make it quicker by creating a fake parameter set and forcing.

In eWaterCycle/ewatercycle@aa38d0d the tests where marked as skipped. This improved CI from 24 minutes to less than 8 minutes.
@BSchilperoort BSchilperoort transferred this issue from eWaterCycle/ewatercycle Nov 2, 2023
@BSchilperoort
Copy link
Member

Was this fixed in dbfe5a8 ?

@sverhoeven
Copy link
Member Author

CI seems to run quick <4min, which is ok.

We should remove the TODO at

ewatercycle-lisflood/tests/test_model.py

Line 43 in d43fe44

# TODO the download can take a long time (> 4 minutes)
to make this issue fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sverhoeven @BSchilperoort