Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design discussion: how do we check a CLI call, and should we? #85

Open
bvreede opened this issue Apr 20, 2021 · 0 comments
Open

Design discussion: how do we check a CLI call, and should we? #85

bvreede opened this issue Apr 20, 2021 · 0 comments

Comments

@bvreede
Copy link
Contributor

bvreede commented Apr 20, 2021

There is a fundamental design discussion we should have about protecting the user against potentially impossible requests. The main reason era5cli exists is to facilitate a data request easily in a workflow, not to make sure a request is solid. There are various checks on the call done at the moment, but they are diffuse and scattered throughout the tool. We could take this two ways:

  1. We implement a single "request checker" that applies all checks (i.e. are the variables correct; are variables possible given the time frame of hourly or monthly; are there no impossible combinations of flags, etc) in one place, so a clear overview gets created and checks are not duplicated or missed.
  2. We do not wish to validate a request but simply translate a quick CLI call into an API request, and let CDS determine whether this results in data or not. This means we will keep the checks inside the tool to a minimum.

There are middle grounds here and combinations, of course, but this is a fundamental conversation we should have that will inform further development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant