Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to remove side space #32

Open
filipjnc opened this issue Aug 2, 2019 · 4 comments
Open

Ability to remove side space #32

filipjnc opened this issue Aug 2, 2019 · 4 comments
Labels
enhancement New feature or request Good Fix Proposed

Comments

@filipjnc
Copy link

filipjnc commented Aug 2, 2019

Currently there is some unfilled side space in width of half gutter.

My mitigation is to set negative margins of this width on the parent container to get this space filled.

Would be nice though to have a built-in option for this.

@mainrs
Copy link

mainrs commented Aug 5, 2019

I was about to create an issue for exactly that. It's weird since the extra width applied to the size doesn't seem to be in correlation with the gutter with for example. Mine is set to 30 but the extra pixels are 27 on each side.

How did you manage to get the right pixel for the margins?

Edit: I just tried applying margin-left and margin-right to by parent but it only works for the left side.

@e-oj This line calculates the width of one column by applying the gutter too. It technically is right, but that would add a gutter to the last column to even if one isn't needed. That would explain the extra space on the right even after applying negative margins to the parent.

@talaxasy
Copy link

I also try to remove this extra space on the sides, but so far unsuccessfully (

@acrylian
Copy link

acrylian commented Apr 4, 2020

It seems to work to set a negativ left and right margin to the container element. Needs a few attempts until it fits as the margin value needed is dependent on the gutter defined. For gutter: 40 negative margins of -28px seem to work for me for example.

@stevenamoody
Copy link

I believe I have a fix for this issue, and I opened a PR. See my proposed implementation of a responsive layout test/grid-responsive.html

@e-oj e-oj added the enhancement New feature or request label Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Good Fix Proposed
Projects
None yet
Development

No branches or pull requests

7 participants