feat(resolve): resolve constants on check too #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @dylanmckay
Like @lukaspustina, I find this crate a holy tool that I will certainly over use ! 🙏
Here is my attempt fixing the
CHECK @variableissue (#5)NOTE:
#[cfg(tes)]It seems like there is a typo on
#[cfg(test)]in src/parse.rs preventing the unit tests to run :lit/src/parse.rs
Line 180 in 652ee63
Activating it made the compiler angry so I changed the tests a bit...
I hope that it still follows the specs you have in mind (:
NOOTE: rustfmt ?
It seems like you are not using the default code formatter as I had to manually disable it to have that "minimal" PR.
Are you against the idea of using it on this project ?
I have to thank lord @sheredom for his inspirational article that convinced me, a lvl 0 Rust-y 🦀, to take a closer look at this testing tool beauty 😏
Fixes #5