Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize DiveProfile.getCeilingError() #217

Open
dylan-smith opened this issue Jun 23, 2024 · 0 comments
Open

Optimize DiveProfile.getCeilingError() #217

dylan-smith opened this issue Jun 23, 2024 · 0 comments

Comments

@dylan-smith
Copy link
Owner

Currently it loops through every time step every time it's called. Can instead calculate it only when the segments change, and only from the changed segment until end of dive.

Could also defer the calculation until getCeilingError is called, and just invalidate the memoized copy when segments change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant