Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update devDependencies #346

Open
3 tasks
nelsonic opened this issue Apr 27, 2020 · 4 comments
Open
3 tasks

Update devDependencies #346

nelsonic opened this issue Apr 27, 2020 · 4 comments
Labels
chore enhancement starter T25m technical

Comments

@nelsonic
Copy link
Member

https://david-dm.org/dwyl/hapi-auth-jwt2?type=dev
image

Todo
@aditya2499
Copy link

I am new to open source community. Can I take this issue?

@nelsonic
Copy link
Member Author

Hi @aditya2499! Welcome to dwyl! 👋
Really appreciate the offer of updating these devDependencies.
If you have experience with Hapi.js and Tape please go for it. 👍
I tried yesterday, but updating Tape to the latest version broke a few tests. 😞

nelsonic added a commit that referenced this issue Apr 28, 2020
@nelsonic
update version of prettier to latest #346
a2505dc
@aditya2499
Copy link

I updated the version of both the modules and all tests passed. Have a look #347

@nelsonic
Copy link
Member Author

@aditya2499 please see: https://travis-ci.org/github/dwyl/hapi-auth-jwt2/jobs/680588777#L236
Sadly, for some reason the Tests fail. 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore enhancement starter T25m technical
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nelsonic @aditya2499