Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erlang '24.0' isn't supported yet ... Deploy Latest Version of App to Heroku #8

Closed
3 tasks done
nelsonic opened this issue Oct 6, 2021 · 7 comments
Closed
3 tasks done
Assignees
Labels
chore a tedious but necessary task often paying technical debt help wanted If you can help make progress with this issue, please comment! please-test Please test the feature in Staging Environment and confirm it's working as expected. T25m Time Estimate 25 Minutes technical A technical issue that requires understanding of the code, infrastructure or dependencies

Comments

@nelsonic
Copy link
Member

nelsonic commented Oct 6, 2021

@SimonLab thanks for merging the update PR #7
Annoyingly, the deploy doesn't work because the buildpack is incorrect (my fault):
https://dashboard.heroku.com/apps/elixir-auth-google-demo/activity/builds/3cb8e486-9ee9-4cbe-9014-b925f6b3eff5
image

-----> Checking Erlang and Elixir versions
       Will use the following versions:
       * Stack heroku-18
       * Erlang 24.0
       * Elixir v1.12.3 
       Sorry, Erlang '24.0' isn't supported yet or isn't formatted correctly. For a list of supported versions, please see https://github.com/HashNuke/heroku-buildpack-elixir#version-support
 !     Push rejected, failed to compile Elixir app.
 !     Push failed

Just checked https://github.com/HashNuke/heroku-buildpack-elixir-otp-builds/blob/master/otp-versions
and it appears the latest available version is 23.3.2:
image

There is a PR to add OTP 24: HashNuke/heroku-buildpack-elixir-otp-builds#166 but it's sitting waiting ... ⏳

I can take a look at this in the evening. Need to do some "work work" now. ⏳

Todo

  • Downgrade OTP version to 23.3.2
  • Create PR
  • Confirm successful deployment to Heroku

This should only take 2 mins but the lowest label we have is T25m ... see: dwyl/labels#99

@nelsonic nelsonic added help wanted If you can help make progress with this issue, please comment! chore a tedious but necessary task often paying technical debt technical A technical issue that requires understanding of the code, infrastructure or dependencies T25m Time Estimate 25 Minutes labels Oct 6, 2021
@nelsonic nelsonic self-assigned this Oct 6, 2021
@nelsonic
Copy link
Member Author

nelsonic commented Oct 6, 2021

PR: #9 :shipit:
Yep, that took less than 5 mins. ⏳

@nelsonic nelsonic assigned SimonLab and unassigned nelsonic Oct 6, 2021
@nelsonic nelsonic added the awaiting-review An issue or pull request that needs to be reviewed label Oct 6, 2021
SimonLab added a commit that referenced this issue Oct 6, 2021
Downgrade OTP version in `elixir_buildpack.config` to 23.3.2 fixes #8
@SimonLab SimonLab added please-test Please test the feature in Staging Environment and confirm it's working as expected. and removed awaiting-review An issue or pull request that needs to be reviewed labels Oct 6, 2021
@SimonLab
Copy link
Member

SimonLab commented Oct 6, 2021

Issue closed automatically when the PR has been merged. Reopen to make sure all working find on Heroku

@SimonLab SimonLab reopened this Oct 6, 2021
@nelsonic
Copy link
Member Author

nelsonic commented Oct 6, 2021

@nelsonic nelsonic closed this as completed Oct 6, 2021
nelsonic added a commit to dwyl/elixir-auth-github-demo that referenced this issue Oct 6, 2021
@ghost
Copy link

ghost commented Nov 30, 2022

Hey, how can I use those elixir and erlang version on my heroku app?

I'm getting this error
image

@nelsonic
Copy link
Member Author

Hey @paij0se 👋
You should be able to use the https://github.com/dwyl/elixir-auth-google-demo/blob/main/elixir_buildpack.config to achieve the same result. 🤞

@ghost
Copy link

ghost commented Nov 30, 2022

I fixed it downgrading the heroku stack to 22 -> 20

@nelsonic
Copy link
Member Author

Makes sense. Glad you figured it out. 👍
If you have the opportunity to try Fly.io in the future, definitely do
it's a muuuuuch slicker Developer Experience for Elixir Apps!
see: https://fly.io/docs/elixir/getting-started/ 🚀
Not affiliated with them. But the creator of Phoenix is. 💭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore a tedious but necessary task often paying technical debt help wanted If you can help make progress with this issue, please comment! please-test Please test the feature in Staging Environment and confirm it's working as expected. T25m Time Estimate 25 Minutes technical A technical issue that requires understanding of the code, infrastructure or dependencies
Projects
None yet
Development

No branches or pull requests

2 participants