Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tag names don't match app versions #12

Open
IzzySoft opened this issue Jan 10, 2019 · 4 comments
Open

tag names don't match app versions #12

IzzySoft opened this issue Jan 10, 2019 · 4 comments

Comments

@IzzySoft
Copy link

Currently, it seems all APKs identify themselves as version 3.0 (versionCode 3). Not only does that not match the tags (which is quite irritating) – but by not increasing versionCode, they are all considered to be the very same version by Android.

Could you please fix that? Thanks a lot!

@dwi336
Copy link
Owner

dwi336 commented Jan 13, 2019

Until now, I just build (and apply changes only for compatibility reasons) from the original sources

https://github.com/LineageOS/android_packages_apps_Eleven/blob/lineage-16.0/AndroidManifest.xml

which also don't increase version number. Introducing an own version numbering would change that concept and I would like to stay as close as possible to the original. Although I currently don't see a big benefit, I will rethink changing the concept at this point.

@IzzySoft
Copy link
Author

Thanks for your reply, @dwi336! So should I report this issue upstream then?

@dwi336
Copy link
Owner

dwi336 commented Jan 13, 2019

That would be the best solution.

Thank you.

@IzzySoft
Copy link
Author

Just tried, they have issues disabled. AFAIK LOS use their own Jira tracker; but I don't want to create just another account for a report 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants