Investigate using a mechanism other than whoami to determine username

[dustymabe]

We should investigate using a mechanism other than whoami to determine username. We do that here

[codylane]

@dustymabe - I'm curious if you've tried using ENV['USER'] instead of whoami for this? I'd be happy to give this a shot and see if this still works as well as put some tests behind it?

[codylane]

There is also the etc ruby module that should be a much richer alternative as well. I'd suggest using the etc module route and here's an example.

[1] pry(main)> require 'etc'
=> false

[2] pry(main)> Etc.getlogin
=> "codylane"

[3] pry(main)> Etc.getpwnam(Etc.getlogin)
=> #<struct Etc::Passwd name="codylane", passwd="********", uid=501, gid=20, gecos="codylane", dir="/Users/codylane", shell="/bin/bash", change=0, uclass="", expire=0>

[4] pry(main)> Etc.getpwnam(Etc.getlogin).uid
=> 501

[5] pry(main)> Etc.getpwnam(Etc.getlogin).gid
=> 20

Here's the etc API doc for reference for 2.6.x which is the version of ruby what Vagrant 2.2.x is using

[dustymabe]

Seems reasonable assuming that module is in the standard library for ruby (i.e. it's not something extra that needs to be installed later).

[codylane]

Agreed, for confirmation etc is part of the standard library. I'll put in a PR with some tests before the end of the week.