Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding spotify tracks to queue performance #61

Closed
xIntern opened this issue Jan 20, 2017 · 2 comments
Closed

Adding spotify tracks to queue performance #61

xIntern opened this issue Jan 20, 2017 · 2 comments

Comments

@xIntern
Copy link

xIntern commented Jan 20, 2017

Hello and thanks for this awesome library!

Im having some performance issues where PHP will reach its default max execution time when adding spotify uris to the queue.

I timed the functions to get these results:
Add 1 spotify uri(s): 0.30468702316284 seconds
(Soap: 0.28796887397766 seconds)
Add 86 spotify uri(s): 41.789011001587 seconds
(Soap: 41.768350124359 seconds)

Add 1 local uri(s): 0.037302017211914 seconds
(Soap: 0.021466970443726 seconds)
Add 170 local uri(s): 4.3112471103668 seconds
(Soap: 4.3003876209259 seconds)

Is it possible to increase performance when adding spotify tracks?

Thanks!

@duncan3dc
Copy link
Owner

Thanks for your report, I'll take a look at what's causing the performance drop and see if it can be improved

@duncan3dc
Copy link
Owner

As long as you're using addTracks() (and not calling addTrack() repeatedly) it doesn't look like there's anything we can do to improve the speed unfortunately.

If we can get Spotify "groups" of tracks (such as albums, playlists, etc) working (#56) then it will be quicker, but if you just want to add 50 odd tracks that aren't part of any existing "group" then it'll always be this slow sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants