Accessor #204

bdestombe · 2023-10-15T19:43:59Z

Tests
Examples
Format

Leaving for a next PR:

Clean up/remove old code
Look for the TODO tags in the code
Version bump
Docs

Solves #200

llvmlite is a pain to install with pip. Alternatively, it could be installed with conda

self.update(out) is still in place at the end

…outines

In preparation of the accessor

and calibration_single_ended to calibrate_ssingle_ended

… monte carlo runs

bdestombe · 2023-10-21T09:29:26Z

Closes #200, #132, #127, #126

BSchilperoort · 2023-10-23T06:47:44Z

Nice work! 🚀 I'll try to find some time to review it this week.

BSchilperoort

Thanks for making all these changes! It's good to finally have moved over to the accessor structure.

It was a lot of code to go through. Some parts I skimmed over more, but the tests seem to not have changed too much so I believe everything still works. The notebooks also still work so that's an extra test suite.

I just have some relatively minor comments, feel free to merge once you have resolved these.

docs/notebooks/01Load_xml_measurement_files.ipynb

docs/notebooks/04Calculate_variance_Stokes.ipynb

src/dtscalibration/__init__.py

src/dtscalibration/calibrate_utils.py

src/dtscalibration/dts_accessor.py

tests/test_examples.py

Co-authored-by: Bart Schilperoort <[email protected]>

bdestombe added 30 commits August 14, 2023 18:00

User-friendly error when setting manually ds.sections

2e8a680

Solves #200

User-friendly error when setting manually ds.sections

07270e3

Solves #200

Revert accidental double implementation of sections.setter

66aa9f0

Update documentation of datastore class

10dfbb4

Removed numbagg from dependencies

77d9ede

llvmlite is a pain to install with pip. Alternatively, it could be installed with conda

Explicitly pass sections to more functions

c18f8ea

Format

bb1b477

Moving away from calibrate_double_ended() inplace

b453f59

self.update(out) is still in place at the end

Refactored calibrate_double_ended covariance calculation

e884f94

Parallel testing

a4a1675

refactored variance functions

f363413

Include pyupgrade flag of ruff

7f795b9

Refactored single ended routine p_val to params and moved averaging r…

7f3dcad

…outines

Update .gitignore

0c427d8

Refactored calibration routines

43f42c8

In preparation of the accessor

Please ruff

e0db37c

Refactored Datastore class

49bbae3

Updated sections example notebook

a515f8b

Updated example notebooks

39f71c9

Add api to docs

a40c810

Unfortenate formatting of notebooks

cfc4c1b

Estimate variance of stokes refactored

ac0ef5f

single_ended_calibration and single_conf_ints working

d0a745d

renamed conf_ints_single_ended to monte_carlo_single_ended

89a5c8d

and calibration_single_ended to calibrate_ssingle_ended

Removed DataStore from being used

ec2a49a

removed renaming_labels test

5e123b7

conf_int_single renamed to monte_carlo_single

c18dd68

Initial commit monte_carlo_double_ended

9286a01

Single and double ended calibration working and tested, including the…

98ce96f

… monte carlo runs

Got several variance_tests working

068305e

bdestombe added 9 commits October 18, 2023 21:54

Update test_variance_stokes.py

0ba5804

Update 15Matching_sections.ipynb

6e97a0e

Updated 16Averaging notebook

a97988d

Update test_examples.py

6ab648a

Update test_examples.py

c70b2d0

Fixing weirdly failing notebooks

1245571

Update test_examples.py

975466a

Rewritten test_notebooks routine

21ecdf9

Removed unused variable

59fd0fd

bdestombe marked this pull request as ready for review October 21, 2023 09:02

bdestombe mentioned this pull request Oct 21, 2023

some problems with resid.plot,ds.tmpw.plot and ds.calibration_double_ended(method=wls) #140

Closed

Remove metadata from notebook 12

bca953d

BSchilperoort approved these changes Oct 26, 2023

View reviewed changes

bdestombe added 2 commits October 27, 2023 14:44

Delete 02Common_DataStore_functions_slice_mean_max_std_resample.ipynb

19d5044

Remove old reference to DataStore in notebooks

4b86bdb

bdestombe mentioned this pull request Oct 27, 2023

Import accessor directly with main package #205

Closed

bdestombe and others added 6 commits October 27, 2023 15:08

Removed references to ds.variance_*() from docs

cba03b6

Update src/dtscalibration/dts_accessor.py

98636ea

Co-authored-by: Bart Schilperoort <[email protected]>

Update test_examples.py

4da18d7

Update docs

1f40022

Minimal attempt to fix docs

b56918b

Update README.rst

2cf247c

bdestombe merged commit 588db04 into main Oct 27, 2023
12 of 13 checks passed

bdestombe deleted the accessor branch October 27, 2023 14:43

This was referenced Oct 27, 2023

User-friendly error when setting manually ds.sections #200

Closed

Define slots explicitly #132

Closed

Storing matching indices #127

Closed

Adding in_place kwarg, to transition to returning the modified DataStore object #126

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Accessor #204

Accessor #204

bdestombe commented Oct 15, 2023 •

edited

Loading

bdestombe commented Oct 21, 2023

BSchilperoort commented Oct 23, 2023

BSchilperoort left a comment •

edited

Loading

Accessor #204

Accessor #204

Conversation

bdestombe commented Oct 15, 2023 • edited Loading

bdestombe commented Oct 21, 2023

BSchilperoort commented Oct 23, 2023

BSchilperoort left a comment • edited Loading

Choose a reason for hiding this comment

bdestombe commented Oct 15, 2023 •

edited

Loading

BSchilperoort left a comment •

edited

Loading