Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split up IO module #203

Merged
merged 24 commits into from
Oct 16, 2023
Merged

Split up IO module #203

merged 24 commits into from
Oct 16, 2023

Conversation

BSchilperoort
Copy link
Collaborator

Fixes #191

Additionally, I have suppressed some common non-useful warnings.

PR #202 has to be merged first.

bdestombe and others added 23 commits August 14, 2023 18:00
@bdestombe
User-friendly error when setting manually ds.sections
2e8a680 
Solves #200
@bdestombe
User-friendly error when setting manually ds.sections
07270e3 
Solves #200
@bdestombe
Revert accidental double implementation of sections.setter
66aa9f0
@bdestombe
Update documentation of datastore class
10dfbb4
@bdestombe
Removed numbagg from dependencies
77d9ede 
llvmlite is a pain to install with pip. Alternatively, it could be installed with conda
@bdestombe
Explicitly pass sections to more functions
c18f8ea
@bdestombe
Format
bb1b477
@bdestombe
Moving away from calibrate_double_ended() inplace
b453f59 
self.update(out) is still in place at the end
@bdestombe
Refactored calibrate_double_ended covariance calculation
e884f94
@bdestombe
Parallel testing
a4a1675
@bdestombe
refactored variance functions
f363413
@bdestombe
Include pyupgrade flag of ruff
7f795b9
@bdestombe
Refactored single ended routine p_val to params and moved averaging r…
7f3dcad 
…outines
@bdestombe
Update .gitignore
0c427d8
@bdestombe
Refactored calibration routines
43f42c8 
In preparation of the accessor
@bdestombe
Please ruff
e0db37c
@bdestombe
Refactored Datastore class
49bbae3
@bdestombe
Updated sections example notebook
a515f8b
@bdestombe
Updated example notebooks
39f71c9
@bdestombe
Add api to docs
a40c810
@bdestombe
Unfortenate formatting of notebooks
cfc4c1b
@BSchilperoort
Split and move IO routines.
7dd73e6
@BSchilperoort
Filter out some common warnings.
62a2c38
@BSchilperoort BSchilperoort marked this pull request as ready for review October 14, 2023 10:28
bdestombe
bdestombe approved these changes Oct 15, 2023
View reviewed changes
Copy link
Collaborator

@bdestombe bdestombe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Bart, Great Work! There is a lot of overlap with the accessor branch though. I am a bit worried we will get into conflicts or are doing things twice..

@bdestombe bdestombe mentioned this pull request Oct 15, 2023
Merged
@bdestombe
Copy link
Collaborator

Hi Bart, Great Work! There is a lot of overlap with the accessor branch though. I am a bit worried we will get into conflicts or are doing things twice..

Wait, which branch did you use as a base?

@BSchilperoort
Copy link
Collaborator Author

BSchilperoort commented Oct 16, 2023 •
edited
Loading

Hi Bart, Great Work! There is a lot of overlap with the accessor branch though. I am a bit worried we will get into conflicts or are doing things twice..

Thanks! I think the overlap is actually not too bad. There will be some conflicts but they shouldn't be too difficult to resolve.
I did not know you were working on the accessor branch, as I didn't see a (draft) PR open.

Compare:
https://github.com/dtscalibration/python-dts-calibration/pull/204/files/cfc4c1b0df46fb596d15c484c3ab00fdc2f361da..068305e654b41f6937291b04e76dc7b22b86349d#diff-1970e631c6f16edf28c2960a27e8b63f7e3d6fc04c34fac7e316eef5f3f6e76d

https://github.com/dtscalibration/python-dts-calibration/pull/203/files/cfc4c1b0df46fb596d15c484c3ab00fdc2f361da..62a2c38afbfddc99903452231372b2d606e4d3e6

Wait, which branch did you use as a base?

I used the Refactor-datastore branch as the base to reduce the merge conflicts, but that didn't work out as I'd hoped 😅

@bdestombe bdestombe merged commit f7f3760 into main Oct 16, 2023
11 of 13 checks passed
@bdestombe bdestombe deleted the split-io branch October 16, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdestombe bdestombe bdestombe approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spliting up io module into more manageable parts
2 participants
@BSchilperoort @bdestombe