Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor datastore #202

Merged
merged 22 commits into from
Oct 16, 2023
Merged

Refactor datastore #202

merged 22 commits into from
Oct 16, 2023

Conversation

bdestombe
Copy link
Collaborator

No description provided.

@bdestombe
Removed numbagg from dependencies
77d9ede 
llvmlite is a pain to install with pip. Alternatively, it could be installed with conda
@bdestombe
Explicitly pass sections to more functions
c18f8ea
@bdestombe
Format
bb1b477
@bdestombe
Moving away from calibrate_double_ended() inplace
b453f59 
self.update(out) is still in place at the end
@bdestombe
Refactored calibrate_double_ended covariance calculation
e884f94
@bdestombe
Parallel testing
a4a1675
@bdestombe
refactored variance functions
f363413
@bdestombe
Include pyupgrade flag of ruff
7f795b9
@bdestombe
Refactored single ended routine p_val to params and moved averaging r…
7f3dcad 
…outines
@bdestombe
Update .gitignore
0c427d8
@bdestombe
Refactored calibration routines
43f42c8 
In preparation of the accessor
@bdestombe
Please ruff
e0db37c
@bdestombe
Refactored Datastore class
49bbae3
@bdestombe
Updated sections example notebook
a515f8b
@bdestombe
Updated example notebooks
39f71c9
@bdestombe
Add api to docs
a40c810
@bdestombe
Unfortenate formatting of notebooks
cfc4c1b
@bdestombe bdestombe marked this pull request as ready for review September 3, 2023 14:51
@bdestombe bdestombe mentioned this pull request Sep 3, 2023
Closed
@BSchilperoort BSchilperoort linked an issue Sep 12, 2023 that may be closed by this pull request
Many DataArrays are stored in the DataStore during double-ended calibration #174
Closed
BSchilperoort
BSchilperoort approved these changes Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@BSchilperoort BSchilperoort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, just some relatively small comments from me. 👍

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
src/dtscalibration/averaging_utils.py Outdated Show resolved Hide resolved
src/dtscalibration/calibration/section_utils.py Show resolved Hide resolved
src/dtscalibration/datastore.py Outdated Show resolved Hide resolved
@BSchilperoort BSchilperoort mentioned this pull request Oct 14, 2023
Merged
@bdestombe
Copy link
Collaborator Author

Do we need to merge this one before your IO split PR? #203

@BSchilperoort
Copy link
Collaborator

Do we need to merge this one before your IO split PR? #203

Yup. That would be easiest.

@bdestombe bdestombe merged commit ea7e2de into main Oct 16, 2023
11 of 13 checks passed
@bdestombe bdestombe deleted the Refactor-datastore branch October 16, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BSchilperoort BSchilperoort BSchilperoort approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Many DataArrays are stored in the DataStore during double-ended calibration
2 participants
@bdestombe @BSchilperoort