Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete From impls of ast enums #1653

Open
dtolnay opened this issue May 15, 2024 · 2 comments
Open

Delete From impls of ast enums #1653

dtolnay opened this issue May 15, 2024 · 2 comments

Comments

@dtolnay
Copy link
Owner

dtolnay commented May 15, 2024

See #1652.

I have not found these impls valuable in practice.

They are originally from #144.

@workingjubilee
Copy link

This removal breaks multiple common ecosystem crates, including some that rustc depends on.

@workingjubilee
Copy link

workingjubilee commented Jul 3, 2024

I suppose, given that this would have to wait for syn 3, that maybe enough crates will have moved on to syn 2 that they can begin migrating to this new syn and overcome the additional points of friction. Though, it is tempting to report a bug if merely expanding and compiling a few From impls is that much of rustc's compile time of syn...

Or larger projects can embrace the tragicomedy of there being 3 syns in their repo.

The possibilities abound!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants