Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

null error on novel18.syosetu.com #1499

Closed
asdfqwerty1029 opened this issue Sep 21, 2024 · 6 comments
Closed

null error on novel18.syosetu.com #1499

asdfqwerty1029 opened this issue Sep 21, 2024 · 6 comments

Comments

@asdfqwerty1029
Copy link

Describe the bug
When parsing a novel from novel18.syosetu.com, I see the following error in firefox:

dom.querySelector(...) is null fetchAndAttachInfoPage@moz-extension://160fc07a-34c6-417b-bf46-fc76ceb43f57/js/parsers/SyosetuParser.js:22:33
getChapterUrls@moz-extension://160fc07a-34c6-417b-bf46-fc76ceb43f57/js/parsers/SyosetuParser.js:13:20
onLoadFirstPage@moz-extension://160fc07a-34c6-417b-bf46-fc76ceb43f57/js/Parser.js:379:14
processInitialHtml@moz-extension://160fc07a-34c6-417b-bf46-fc76ceb43f57/js/main.js:48:24
populateControlsWithDom@moz-extension://160fc07a-34c6-417b-bf46-fc76ceb43f57/js/main.js:253:27
onMessageListener@moz-extension://160fc07a-34c6-417b-bf46-fc76ceb43f57/js/main.js:16:36

And a similar error in chrome:

TypeError: Cannot read properties of null (reading 'href')
    at SyosetuParser.fetchAndAttachInfoPage (chrome-extension://akiljllkbielkidmammnifcnibaigelm/js/parsers/SyosetuParser.js:22:81)
    at SyosetuParser.getChapterUrls (chrome-extension://akiljllkbielkidmammnifcnibaigelm/js/parsers/SyosetuParser.js:13:20)
    at SyosetuParser.onLoadFirstPage (chrome-extension://akiljllkbielkidmammnifcnibaigelm/js/Parser.js:379:14)
    at processInitialHtml (chrome-extension://akiljllkbielkidmammnifcnibaigelm/js/main.js:48:24)
    at populateControlsWithDom (chrome-extension://akiljllkbielkidmammnifcnibaigelm/js/main.js:253:9)
    at onMessageListener (chrome-extension://akiljllkbielkidmammnifcnibaigelm/js/main.js:16:13)

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://novel18.syosetu.com/ and choose a novel
  2. Click on the webtoepub extension button
  3. See error

Expected behavior
The webtoepub tab should open with the parsed novel

Desktop (please complete the following information):

  • OS: Linux
  • Browser Firefox (127.0.2), Chrome (129.0.6668.58)

Thanks very much for this extension, it has been very helpful on several sites!

@gamebeaker
Copy link
Collaborator

@asdfqwerty1029 i don't know japanese can you post a novel link? I don't find a novel on https://novel18.syosetu.com/ only redirect links to https://yomou.syosetu.com/ or https://noc.syosetu.com/top/top/ etc.

@BeetleBobsai79
Copy link

same issue also happens on ncode.syosetu.com with any novel.

@asdfqwerty1029
Copy link
Author

@gamebeaker sure thing, here are a couple of examples:
https://novel18.syosetu.com/n8333im/
https://ncode.syosetu.com/n6316bn/

@gamebeaker
Copy link
Collaborator

@asdfqwerty1029 @BeetleBobsai79
Test versions for Firefox and Chrome have been uploaded to https://github.com/dteviot/WebToEpub/releases/tag/developer-build. Pick the one suitable for you, follow the "How to install from Source (for people who are not developers)" instructions at https://github.com/dteviot/WebToEpub/tree/ExperimentalTabMode#user-content-how-to-install-from-source-for-people-who-are-not-developers and let me know how it goes.
Tested with:

@asdfqwerty1029
Copy link
Author

Thanks @gamebeaker, the new version works great!

@dteviot
Copy link
Owner

dteviot commented Sep 26, 2024

@asdfqwerty1029 @BeetleBobsai79
Updated version (1.0.0.0) has been submitted to Firefox and Chrome stores.
Firefox version is available now.
Chrome might be available in a few hours to 21 days.

@dteviot dteviot closed this as completed Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants