-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: change clampSimultanousFetchSize() #1468
Comments
User is not supposed to be able to override clampSimultanousFetchSize(). It's applied on a per parser (i.e. Site) basis, for sites that don't like rates of more than 1 page at a time. |
@dteviot i would argue that this.minimumThrottle is the same as in that if it is defined in a parser it is normally required or you get rate limited. So the user should not change minimumThrottle but are still able todo it if they want. |
@gamebeaker |
|
@dteviot and we don't violate the TOS... |
Isn't that the case currently? Or do you mean the settings should be saved per site/ parser?
Change in html default value should do the trick.
I would interpret it like this:
and a function similar to |
I thought if user makes changes in the UI, they are applied to every site/parser. Or did your changes alter that? |
Ok i am not sure how this should be implemented.
I haven't made changes at the moment just ideas.
Aren't these two things contradictory? As an other idea:
In the html droppdown to select add a new option named "default" as the new default value. I like this option because it provides default values while still allowing the user to change it like he wants. I for example use the library function and if i update the ebooks and there are mostly only one or two new chapters i don't need a slow down for the site. (I know edge case...) I would argue that these options are under "Advanced Options" and if user break things because they configure it to fast for the website (HTTP 426) they are unlucky the same as when you use your cli with sudo or admin rights and you make a mistake. |
@gamebeaker
What I think should happen (where we want to be) is when the settings are changed, the change only applies to the current site/parser. i.e. The user should not need to manually change the speed settings each time they want to download from a different site. |
Change
clampSimultanousFetchSize()
so that it is the same asthis.minimumThrottle = 3000;
I think a variable is more elegant than a function and at the moment the user is unable to overwrite
clampSimultanousFetchSize()
.Todo:
clampSimultanousFetchSize()
to a variableThe text was updated successfully, but these errors were encountered: