-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem converting tables from Royal Road #1455
Comments
I'm not sure I can help you. I just tried to download an view that chapter. I have seen similar problems (as your Tolino Shine 3) with the table being cut in Edge, when it use to support epubs. So, I think it's a flaw in your viewer's handling of a table, it only shows as much of the table as will fit on a page. I tried viewing it in Calibre, and all the text appears. |
I also have a tolino shine 3 and wrote to the tolino support, if i get a response i am going to post it here. Here is the test epub file i created to simulate the problem https://nx39171.your-storageshare.de/s/42djZXf5ESZPFXb (The funny thing is if you open the epub in the browser->click "..." -> "Open in Onlyoffice" it is displayed correct). |
So i tested a bit, and calibre indeed does show the whole text, if i maximize the windows of the reader. I never read on my pc so it was still at the default size, which is small. |
No response from tolino just found this reddit thread. |
Thought occurs, I could probably throw something together for EpubEditor to reformat the table as ordinary text. Not sure it that would be acceptable for you or not. |
Hi, i mean that would be way better than not being able to read it. |
@gamebeaker |
I just made a test with this website: https://www.academicblock.com/technology/web-tools/table-to-div-convertor |
@dteviot i am not sure how to implement this should the user have the ability to choose if it gets converted or not? |
@bardokhofmeier896 i made a fix you have to install the test version. Test versions for Firefox and Chrome have been uploaded to https://github.com/dteviot/WebToEpub/releases/tag/developer-build. Pick the one suitable for you, follow the "How to install from Source (for people who are not developers)" instructions at https://github.com/dteviot/WebToEpub/tree/ExperimentalTabMode#user-content-how-to-install-from-source-for-people-who-are-not-developers and let me know how it goes. and add in the Stylesheet:
this will convert the tables to divs with a little styling. |
@gamebeaker |
@gamebeaker I want to keep WebToEpub as simple and minimal as possible. Also, I'm really not comfortable with the feature being turned on by adding values to the stylesheet. It's: However, you've done this work, it's not a big piece of code, and it obviously solves a problem. So, I'm going to split the baby and propose: make it a full feature. But if it causes problems in the future, I'll remove it (and provide a EpubEditor script.) So, additional work needed.
|
@dteviot i could move the stylesheet directly into the generated html. |
@dteviot @gamebeaker This works like a charm. |
I think you're suggesting have WebToEpub add this to the stylesheet when feature is turned on? |
@dteviot i thought more of something like this in the HTML.
yea |
Thanks to gamebeaker, EpubEditor is now available at https://dteviot.github.io/EpubEditor/, no need to download, unpack, etc. |
@bardokhofmeier896 The fix for royalroad got removed from WebToEpub you now need to use EpubEditor to convert the tables for better readability. |
That works for me, thanks a lot for all the work :) |
Describe the bug
I read a lot of LitRpg and they startet adding html table for ingame status messages. These messages, if to long, don't convert properly and can't be read on my reader.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
I want to read the whole text of the box.
Screenshots
Page with the table:
Next page:
Actual content of the box:
If i open the book in calibre it's also cut at the same point.
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: