-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance QuestionableQuesting: Export all posts (including non-threadmark posts) to epub #1454
Comments
@xypha lucky you... |
@gamebeaker At this point we can be fairly confident that zawa999 is violating GitHub's Terms of Service - before deleting comments in the future, it's probably worth reporting their content for chance at a full IP ban. I'd do it, but you seem to find & delete them before I see them xD As for the mentioned issue, I've actually been thinking of something similar for all Xenforo forums, mostly for the perspective of bulk threadmark download through "Reader Mode", however it would work similarly for this case as well. One issue: it runs into a few faults - mostly with WebToEpubs indexing logic - e.g. Each chapter link is pre-defined before generation begins, which would be impossible under this paging structure. That can theoretically be worked around, but even if it can, it won't work the exact same as other sites. I'll look at a potential solution on this but if one is possible, it will likely require configuration in [WebToEpub > Advanced Options > Manually Select Parser] to differentiate it from the standard, unless someone has a better idea for handling this case. |
@Kiradien I don't understand Scenario 3 As regards Scenario 2, Am I missing something? WebToEpub could be made to detect there's multiple ToC pages, and fetch them. URL for each page seems to be like: https://forum.questionablequesting.com/threads/with-this-ring-young-justice-si-story-only.8961/threadmarks?per_page=25&page=4 |
Yeah, this enhancement is entirely edge-cases; I understand why you're confused, it's also why I will not add these fixes to the main parser. The UI is also different for this archive page, normally paging isn't really needed for threadmarks... it's a really odd edgecase. Some notes of my own: |
@Kiradien |
@xypha No worries, that is actually what I'm working on. Just taking time since I'm poking around elements I don't usually touch in my free time. It might end up being a bit buggy on chapter titles (Since the title is usually pulled from the 'threadmark'), but the goal should be feasible... Just a bit slower to release than most patches I work on. My comments about 'Reader Mode' is simply because that is what I will personally use it to export, no intent to make it exclusive to that. |
Hi. I made a CLI tool for adding images to FicHub here. You'll have to install python to use it though |
Test versions for Firefox and Chrome have been uploaded to https://github.com/dteviot/WebToEpub/releases/tag/developer-build. Pick the one suitable for you, follow the "How to install from Source (for people who are not developers)" instructions at https://github.com/dteviot/WebToEpub/tree/ExperimentalTabMode#user-content-how-to-install-from-source-for-people-who-are-not-developers and let me know how it goes. |
@Kiradien Thank you! Saw a bunch of errors - mostly about fetching images, but also others. No complaints though. THANK YOU! this is what I wanted. Just going to share the errors here in case they might be relevant.
Example :
|
I had a quick skim through them. All I saw were WebToEpub reporting it was unable to retrieve an image. (So you know it won't be in the epub, and it's not WebToEpub's fault.) e.g. http://static.comicvine.com seems to be down/gone |
Thank you! |
Problem
Non-threadmark posts cannot be exported.
Steps to replicate:
WebToEpub
from toolbar icon → only 1 chapter is loaded. None of the threadmarks on the page are seen.WebToEpub
from toolbar icon → only 25 chapters are loaded.WebToEpub
from toolbar icon → all 148 chapters are loaded, but non-threadmark posts cannot be exported.Describe the solution you'd like
Possible solution to Scenario 1 and 2:
WebToEpub
popup tab, add warning text (maybe above the Chapters Count), telling users to ensure all threadmarks are loaded before export.Possible solution to Scenario 3:
Describe alternatives you've considered
Exporting through FicHub (also on GitHub) solves Scenario 1 and 2 - but fails to export images (which is a deal breaker).
For Scenario 3, the problem persists. Non-threadmark posts cannot be exported.
Additional context
Current version: 0.0.0.167
Browser: Firefox 129.0.2 (64-bit)
OS: Windows 11 23H2
The text was updated successfully, but these errors were encountered: