Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix Reliability plot XML with EE loads to UI incorrectly #494

Closed
22 tasks
TatianaBurek opened this issue Oct 13, 2023 · 1 comment · Fixed by #496
Closed
22 tasks

Bugfix Reliability plot XML with EE loads to UI incorrectly #494

TatianaBurek opened this issue Oct 13, 2023 · 1 comment · Fixed by #496
Assignees
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue METviewer: User Interface priority: high High Priority type: bug Fix something that is not working

Comments

@TatianaBurek
Copy link
Collaborator

TatianaBurek commented Oct 13, 2023

Describe the Problem

EE check boxes for Reliability plot don't get checked when XML is loaded to GUI
plot_20231013_193708.xml.txt

Remove "If agg_stat is turned on, event equalization must be turned off (it is done automatically)" from the documentations since it is invalid

Expected Behavior

EE check boxes should be checked

Environment

Describe your runtime environment:
1. Machine: (e.g. HPC name, Linux Workstation, Mac Laptop)
2. OS: (e.g. RedHat Linux, MacOS)
3. Software version number(s)

To Reproduce

Describe the steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error
Post relevant sample data following these instructions:
https://dtcenter.org/community-code/model-evaluation-tools-met/met-help-desk#ftp

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Organization level Project for support of the current coordinated release
  • Select Repository level Project for development toward the next official release or add alert: NEED CYCLE ASSIGNMENT label
  • Select Milestone as the next bugfix version

Define Related Issue(s)

Consider the impact to the other METplus components.

Bugfix Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of main_<Version>.
    Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
  • Fix the bug and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into main_<Version>.
    Pull request: bugfix <Issue Number> main_<Version> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues
    Select: Organization level software support Project for the current coordinated release
    Select: Milestone as the next bugfix version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Complete the steps above to fix the bug on the develop branch.
    Branch name: bugfix_<Issue Number>_develop_<Description>
    Pull request: bugfix <Issue Number> develop <Description>
    Select: Reviewer(s) and Development issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Close this issue.
@TatianaBurek TatianaBurek added type: bug Fix something that is not working priority: high High Priority alert: NEED ACCOUNT KEY Need to assign an account key to this issue METviewer: User Interface labels Oct 13, 2023
@TatianaBurek TatianaBurek added this to the METviewer-6.0.0 milestone Oct 13, 2023
@TatianaBurek TatianaBurek self-assigned this Oct 13, 2023
@gsketefian
Copy link

@TatianaBurek I wanted to point out that the documentation here says:

If agg_stat is turned on, event equalization must be turned off (it is done automatically).

Will this restriction still be applied in this bugfix? Also, this apparently applies to all statistic types since the documentation doesn't say that it's restricted to only reliability plots. Do you interpret it that way as well?
Thanks.

TatianaBurek added a commit that referenced this issue Oct 16, 2023
TatianaBurek added a commit that referenced this issue Oct 16, 2023
@TatianaBurek TatianaBurek linked a pull request Oct 16, 2023 that will close this issue
13 tasks
@TatianaBurek TatianaBurek moved this from 🆕 New to ✅ Done in METplus-Analysis-6.0.0 Development Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue METviewer: User Interface priority: high High Priority type: bug Fix something that is not working
Projects
Status: 🏁 Done
Development

Successfully merging a pull request may close this issue.

2 participants