Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up use case documentation files #681

Open
4 of 22 tasks
georgemccabe opened this issue Nov 2, 2020 · 4 comments · Fixed by #916
Open
4 of 22 tasks

Clean up use case documentation files #681

georgemccabe opened this issue Nov 2, 2020 · 4 comments · Fixed by #916
Assignees
Labels
component: documentation Documentation issue priority: medium Medium Priority requestor: NCAR National Center for Atmospheric Research type: task An actionable item of work

Comments

@georgemccabe
Copy link
Collaborator

georgemccabe commented Nov 2, 2020

There are a handful of text that are identical in every use case doc file that should be cleaned up and improved in across the board.

One example is the way we word the "Running METplus" section requires us to modify the name of the new config 4 times. We also have discussed improving how we show how METplus config variables correspond to MET config variables (#402).

Describe the Task

We should clean up the information in these files so it is easier to create a new use case. Things to consider:

  • If there is text that is the same in every file, consider if that text belongs in another file instead and linked to. If it does make sense in these files, consider pulling it out into an RST file and including it so it can be edited in one place.
  • Reduce the number of times a config file path needs to be updated for a new use case. This is a tedious part of the process of adding a new use case.
  • Improve documentation on mapping METplus configuration items to MET config file env vars #402
  • For example, "See the 'User Defined Config' section on the 'System Configuration' page of the METplus User's Guide for more information.", consider consider linking the user to this section directly. The instructions for doing this are listed under the Internal Links in the Documentation section of the Documentation Overview and Conventions section of the Contributor's Guide.
  • Add a period to this sentence "This must be in a location where you have write permissions"
  • Add a period to this sentence "This is not required to run METplus, but it is required to run the examples in parm/use_cases"
  • add more here

Time Estimate

3+ days

Sub-Issues

Consider breaking the task down into sub-issues.

Relevant Deadlines

None

Funding Source

None

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Review projects and select relevant Repository and Organization ones or add "alert:NEED PROJECT ASSIGNMENT" label
  • Select milestone to next major version milestone or "Future Versions"

Define Related Issue(s)

Consider the impact to the other METplus components.

Task Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s), Project(s), Milestone, and Linked issues
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@georgemccabe georgemccabe added component: use case configuration component: documentation Documentation issue priority: high High Priority type: task An actionable item of work requestor: NCAR National Center for Atmospheric Research labels Nov 2, 2020
@georgemccabe georgemccabe added this to the METplus-4.0 milestone Nov 2, 2020
@bikegeek bikegeek added priority: medium Medium Priority and removed priority: high High Priority labels Dec 15, 2020
@georgemccabe georgemccabe mentioned this issue Apr 14, 2021
11 tasks
@georgemccabe
Copy link
Collaborator Author

From PR #882, we found a few minor edits to apply to the repeated content for each use case. To avoid redundancy, we could move the common content to another file to reference in each use case doc.

Suggested changes:

Change (Click here to see the METplus releases):

# | **Location:** All of the input data required for this use case can be found in the met_test sample data tarball. Click here to the METplus releases page and download sample data for the appropriate release: https://github.com/dtcenter/METplus/releases

to

# | **Location:** All of the input data required for this use case can be found in the met_test sample data tarball. Click here to see the METplus releases page and download sample data for the appropriate release: https://github.com/dtcenter/METplus/releases

Change (parm/metplus_config, then to parm/metplus_config and then):

# 2) Modifying the configurations in parm/metplus_config, then passing in METdbLoad.conf::

to

# 2) Modifying the configurations in parm/metplus_config and then passing in METdbLoad.conf::

Change (Path where METplus to Path to directory where METplus):

# * **OUTPUT_BASE** - Path where METplus output will be written. This must be in a location where you have write permissions

to

# * **OUTPUT_BASE** - Path to directory where METplus output will be written. This must be in a location where you have write permissions

@jprestop
Copy link
Collaborator

@georgemccabe I see a note above that says "georgemccabe linked a pull request on May 6, 2021 that will close this issue", but I see that this issue is still Open. Should it be closed?

@georgemccabe
Copy link
Collaborator Author

@jprestop, no, I don't think that PR completes this work. I think that note was generated because the PR was linked to this issue under "Development."

This issue seems related to #918, which @j-opatz is working on. John, could you refer to this issue to ensure that the changes mentioned here are covered in the use case doc template work?

@jprestop
Copy link
Collaborator

Thanks for the clarification @georgemccabe. I've been trying to help go through issues with @lisagoodrich to help her find things to work on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: documentation Documentation issue priority: medium Medium Priority requestor: NCAR National Center for Atmospheric Research type: task An actionable item of work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants