Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Use Case: Add a use case (or use cases) demonstrating the UGRID functionality in MET #2576

Open
24 tasks
DanielAdriaansen opened this issue May 6, 2024 · 4 comments
Assignees
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED MORE DEFINITION Not yet actionable, additional definition required priority: high High Priority requestor: NCAR National Center for Atmospheric Research requestor: NOAA/EMC NOAA Environmental Modeling Center requestor: UK Met Office United Kingdom Met Office type: new use case Add a new use case
Milestone

Comments

@DanielAdriaansen
Copy link
Contributor

DanielAdriaansen commented May 6, 2024

Describe the New Use Case

After the updates to GridStat and PointStat in MET to support unstructured grids, we should implement a new use case demonstrating the verification of some of the sample FCST data we received for testing in the METplus Wrappers repository.

The tests that we used during MET development included:

  1. Verify significant wave height from GLWU wave model from EMC/NOAA using buoy data (PointStat)
  2. Verify LFRIC 2D 10m U-wind using ADPSFC PREPBUFR Uwind (PointStat)
  3. Verify MPAS post-processed diagnostic temperature at 500 hPa using ADPUPA Temperature from PREPBUFR (PointStat)

We could consider a new Model Applications use case category for "UGRID", or put these where they fit otherwise (e.g. #1 would go under "marine and cryosphere").

Use Case Name and Category

Provide use case name, following Contributor's Guide naming template, and list which category the use case will reside in.
If a new category is needed for this use case, provide its name and brief justification

Input Data

List input data types and sources.
Provide a total input file size, keeping necessary data to a minimum.

Acceptance Testing

Describe tests required for new functionality.
As use case develops, provide a run time here

Time Estimate

Approximately 2 days of work for @DanielAdriaansen.

Sub-Issues

Consider breaking the new feature down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)
  • Select privacy

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED CYCLE ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

New Use Case Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept your changes. Merge branch into develop.
  • Create a second pull request to merge develop into develop-ref, following the same steps for the first pull request.
  • Delete your fork or branch.
  • Close this issue.
@DanielAdriaansen DanielAdriaansen added alert: NEED ACCOUNT KEY Need to assign an account key to this issue type: new use case Add a new use case labels May 6, 2024
@DanielAdriaansen DanielAdriaansen added this to the METplus-6.0.0 milestone May 6, 2024
@DanielAdriaansen DanielAdriaansen self-assigned this May 6, 2024
@DanielAdriaansen DanielAdriaansen added the alert: NEED MORE DEFINITION Not yet actionable, additional definition required label May 6, 2024
@JohnHalleyGotway JohnHalleyGotway added the requestor: UK Met Office United Kingdom Met Office label May 9, 2024
@AliciaBentley-NOAA
Copy link

@JohnHalleyGotway @DanielAdriaansen Here is a METplus issue related to adding "Unstructured Grids" in METplus-6.0.0 (along with MET issues dtcenter/MET#2746 and dtcenter/MET#2860) . Does this particular METplus issue also need to be finished in order for Unstructured grids to be added to METplus-6.0.0? If this issue is required in order to add unstructured grids, can it please be marked as a blocker to the METplus-6.0.0 official release? Thank you!

@JohnHalleyGotway JohnHalleyGotway added priority: high High Priority requestor: NOAA/EMC NOAA Environmental Modeling Center requestor: NCAR National Center for Atmospheric Research labels May 15, 2024
@AliciaBentley-NOAA
Copy link

AliciaBentley-NOAA commented May 29, 2024

@j-opatz @georgemccabe Here is a METplus issue related to adding "Unstructured Grids" in METplus-6.0.0 (along with MET issues dtcenter/MET#2746 and dtcenter/MET#2860) . Does this particular METplus issue also need to be finished in order for Unstructured grids to be added to METplus-6.0.0? If this issue is required in order to add unstructured grids, can it please be marked as a blocker to the METplus-6.0.0 official release? Thank you!

@georgemccabe
Copy link
Collaborator

Hi @AliciaBentley-NOAA, unless there is a specific requirement to provide a METplus use case demonstrating the use of the new unstructured grid functionality, I don't think this issue necessarily required. The new unstructured grid read capabilities can still be used without an example. That said, it is very useful for users to have a concrete example. I think it would be worthwhile to finish this task while the details are fresh, but it isn't preventing the functionality from being available to users in METplus 6.0.0.

@AliciaBentley-NOAA
Copy link

@georgemccabe Thank you for clarifying! If this is not required to have this functionality in METplus-6.0.0, then I agree that it actually doesn't need to be marked as required for the official release. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED MORE DEFINITION Not yet actionable, additional definition required priority: high High Priority requestor: NCAR National Center for Atmospheric Research requestor: NOAA/EMC NOAA Environmental Modeling Center requestor: UK Met Office United Kingdom Met Office type: new use case Add a new use case
Projects
Status: 🟢 Ready
Development

No branches or pull requests

4 participants