Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taylor diagram is not using fcst_var_val_1/2 values in creating queries #434

Open
23 tasks
bikegeek opened this issue Apr 15, 2024 · 1 comment
Open
23 tasks
Assignees
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle alert: NEED MORE DEFINITION Not yet actionable, additional definition required METplotpy: Plots requestor: METplus Team METplus Development Team requestor: NOAA/EMC NOAA Environmental Modeling Center type: enhancement Improve something that it is currently doing

Comments

@bikegeek
Copy link
Collaborator

bikegeek commented Apr 15, 2024

Replace italics below with details for this issue.

Describe the Problem

While addressing some questions about generating Taylor Diagrams via METplus Discussions, it has been discovered that the fcst_var_val_1 setting in the Taylor Diagram yaml config file is NOT being used. Users will need to set the fcst var under the series_val_1 setting to include the fcst_var value to be used in querying and filtering the input data.

Additionally, the dump_points support isn't available. The fcstdev, ostdev, and pr_corr values should be saved to a file when dump_points is set to True.

Expected Behavior

Provide a clear and concise description of what you expected to happen here.

Environment

Describe your runtime environment:
1. Machine: (e.g. HPC name, Linux Workstation, Mac Laptop)
2. OS: (e.g. RedHat Linux, MacOS)
3. Software version number(s)

To Reproduce

Describe the steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error
Post relevant sample data following these instructions:
https://dtcenter.org/community-code/model-evaluation-tools-met/met-help-desk#ftp

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Organization level Project for support of the current coordinated release
  • Select Repository level Project for development toward the next official release or add alert: NEED CYCLE ASSIGNMENT label
  • Select Milestone as the next bugfix version

Define Related Issue(s)

Consider the impact to the other METplus components.

Bugfix Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of main_<Version>.
    Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
  • Fix the bug and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into main_<Version>.
    Pull request: bugfix <Issue Number> main_<Version> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues
    Select: Organization level software support Project for the current coordinated release
    Select: Milestone as the next bugfix version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Complete the steps above to fix the bug on the develop branch.
    Branch name: bugfix_<Issue Number>_develop_<Description>
    Pull request: bugfix <Issue Number> develop <Description>
    Select: Reviewer(s) and Development issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Close this issue.
@bikegeek bikegeek added type: bug Fix something that is not working priority: high High Priority alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle requestor: METplus Team METplus Development Team required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone METplotpy: Plots labels Apr 15, 2024
@bikegeek bikegeek added this to the METplotpy-3.0.0 milestone Apr 15, 2024
@bikegeek bikegeek self-assigned this Apr 15, 2024
@bikegeek bikegeek added type: enhancement Improve something that it is currently doing and removed type: bug Fix something that is not working labels Jun 26, 2024
@bikegeek
Copy link
Collaborator Author

This is something that should be handled by the not-yet available aggregation support that will be in the METcalcpy repository

@bikegeek bikegeek added requestor: NOAA/EMC NOAA Environmental Modeling Center and removed priority: high High Priority required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone labels Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle alert: NEED MORE DEFINITION Not yet actionable, additional definition required METplotpy: Plots requestor: METplus Team METplus Development Team requestor: NOAA/EMC NOAA Environmental Modeling Center type: enhancement Improve something that it is currently doing
Projects
None yet
Development

No branches or pull requests

1 participant