Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support reading MET columns that are all uppercase in Taylor diagram #433

Open
22 tasks
bikegeek opened this issue Apr 12, 2024 · 0 comments
Open
22 tasks
Assignees
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle alert: NEED MORE DEFINITION Not yet actionable, additional definition required type: enhancement Improve something that it is currently doing

Comments

@bikegeek
Copy link
Collaborator

bikegeek commented Apr 12, 2024

Describe the Enhancement

Note that this issue originated from the dtcenter/METplus#2546 discussion.

The METplotpy Taylor diagram (and perhaps other plots) can use MET .stat output without prior reformatting via METdataio's METreformat. However, MET column headers are all uppercase and lower case column headers are expected by METplotpy (consistent with METviewer). Enable the Taylor diagram (and other possible METplotpy plots) to read in this data and internally convert the column header names to lower case.

Time Estimate

less than 1 day for Taylor diagram

maximum 2 days

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED CYCLE ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@bikegeek bikegeek added type: enhancement Improve something that it is currently doing alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Apr 12, 2024
@bikegeek bikegeek added this to the METplotpy-3.0.0 milestone Apr 12, 2024
@bikegeek bikegeek self-assigned this Apr 12, 2024
@bikegeek bikegeek changed the title Support reading MET columns that are all uppercase Support reading MET columns that are all uppercase in Taylor diagram May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle alert: NEED MORE DEFINITION Not yet actionable, additional definition required type: enhancement Improve something that it is currently doing
Projects
None yet
Development

No branches or pull requests

1 participant