-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance the OBTYPE
header column for MPR
and ORANK
line types
#2893
Comments
Just an additional bit of context regarding this change. It could be asked as to why couldn't you have 2 GROUP_MAP keys, one just containing AUTO and one just MANU and then run your job from that. |
…and Ensemble-Stat that applies when writing MPR, SEEPS_MPR, and ORANK line types. If true, write the input observation message type to the OBTYPE output column rather than the name of the group.
…at already include the message_type_group_map entry.
…it write MPR output with obtype_as_group_val_flag = TRUE. Note that I switched the message types from ADPSFC, SFCSHP, USERSF to just USERSF. The original reason for the 3 was to prove that the counts for ADPSFC + SFCSHP = USERSF.
…pe_as_group_val_flag option.
… and ORANK line types in Point-Stat
* Per #2893, add obtype_as_obs_message_type_flag option for Point-Stat and Ensemble-Stat that applies when writing MPR, SEEPS_MPR, and ORANK line types. If true, write the input observation message type to the OBTYPE output column rather than the name of the group. * Per #2893, add option to default config files and fix compilation errors. * Per #2893, change the name from obtype_as_obs_message_type_flag to obtype_as_group_val_flag. * Per #2893, add docs ci-run-unit * Per #2893, add obtype_as_group_val_flag entry for all config files that already include the message_type_group_map entry. * Per #2893, modify existing PointStatConfig_WINDS config file to have it write MPR output with obtype_as_group_val_flag = TRUE. Note that I switched the message types from ADPSFC, SFCSHP, USERSF to just USERSF. The original reason for the 3 was to prove that the counts for ADPSFC + SFCSHP = USERSF. * Per #2893, update commit history for ensemble_stat and point_stat * Per #2893, revert back PointStatConfig_WINDS to minimize diffs * Per #2893, add a Point-Stat unit test to demonstrate setting the obtype_as_group_val_flag option. * Per #2893, need to reset the obtype after writing all MPR, SEEPS_MPR, and ORANK line types in Point-Stat * Per #2893, tweak Point-Stat configuration to also write HIRA ORANK and PCT outputs.
Describe the Enhancement
This issue arose via dtcenter/METplus#2476 discussion from @robdarvell.
The
OBTYPE
stat header column is populated based on the message type specified in the Point-Stat and Ensemble-Stat configuration files. The sameOBTYPE
string is written for all STAT output line types generated by each verification task, including the matched pair (MPR
) and observation rank (ORANK
) line types.However, the
message_type_group_map
configuration option enables multiple input message types to be grouped together into the same verification task. In Rob's example he's grouping bothAUTO
andMANU
message types together into a group namedSURF
. Rather than settingOBTYPE
toSURF
in output MPR lines, he'd prefer to write the input obtype name instead.This task is to enhance the Point-Stat and Ensemble-Stat tools where the
message_type_group_map
is involved in the setting of theOBTYPE
output column. Provide the option of writingOBTYPE
for theMPR
andORANK
lines using the original input message type rather than the mapped name of the group.Recommend adding this logic through a configurable option rather than making a wholesale change:
obtype_as_group_val_flag = FALSE
Where
FALSE
(default) maintains the current behavior of writingSURF
, andTRUE
would write the original observation message types ofAUTO
ofMANU
instead.This would support the MetOffice usage without changing the output for others.
Time Estimate
2 days?
Sub-Issues
Consider breaking the enhancement down into sub-issues.
None needed.
Relevant Deadlines
List relevant project deadlines here or state NONE.
Funding Source
2799991
Define the Metadata
Assignee
Labels
Milestone and Projects
Define Related Issue(s)
Consider the impact to the other METplus components.
Enhancement Checklist
See the METplus Workflow for details.
Branch name:
feature_<Issue Number>_<Description>
Pull request:
feature <Issue Number> <Description>
Select: Reviewer(s) and Development issue
Select: Milestone as the next official version
Select: MET-X.Y.Z Development project for development toward the next official release
The text was updated successfully, but these errors were encountered: