-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to G2C library version that supports CCSDS encoding #2759
Comments
@JohnHalleyGotway After moving this issue forward to 12.1.0, I looked into this issue further. The description of this issue includes:
Note that the referenced NCEPLIBS-g2c issue is currently closed, however, after reading through the comments, there were no changes made. The developer suggests to the user that there "could be an incompatibility between g2c (built with MSVC++) and g2 (Intel Fortran) and your program (Intel Fortran) what does not show itself until program execution". And then indicated:
However, we are not using g2, but rather only g2c. I'm not sure where this leaves us. I don't have a full understanding of the underlying issue, but am wondering if you think we need to submit an issue to g2c for this problem? |
@mollybsmith-noaa Please see my comment above. It looks like no fix is coming for this issue. Please let us know if you have any concerns. |
@jprestop The re-encoding via wgrib2 is an acceptable workaround, albeit clunky, so the fix is not vital at this point. |
@mollybsmith-noaa Thank you. I'm going to close this issue as "not planned". We can reopen it in the future if necessary. |
Describe the Enhancement
METplus Discussion dtcenter/METplus#2449 points out a segfault from MET when processing GRIB2 files from ECMWF encoded using the CCSDS encoding option. The problem lies not in MET itself, but in the GRIB2C Library (G2C) to which MET links.
As noted in this Discussion Comment pre-processing the GRIB2 files using the
grib_set
orwgrib2
utilities to change the encoding method provide a temporary workaround.This issue is to monitor the progress on issue NOAA-EMC/NCEPLIBS-g2c#461 which is meant to fix the underlying problem in the GRIB2C library. When that issue is fixed and an updated version of the G2C library is released, update the MET compilation script as needed to begin using the new version of that library.
Consider recompiling the existing MET builds for MET version 11.1.0 and MET version 12.0.0 using the updated G2C library version, as needed.
Time Estimate
3 days?
Sub-Issues
Consider breaking the enhancement down into sub-issues.
None needed.
Relevant Deadlines
List relevant project deadlines here or state NONE.
Funding Source
Define the source of funding and account keys here or state NONE.
Define the Metadata
Assignee
Labels
Milestone and Projects
Define Related Issue(s)
Consider the impact to the other METplus components.
No impacts.
Enhancement Checklist
See the METplus Workflow for details.
Branch name:
feature_<Issue Number>_<Description>
Pull request:
feature <Issue Number> <Description>
Select: Reviewer(s) and Development issue
Select: Milestone as the next official version
Select: MET-X.Y.Z Development project for development toward the next official release
The text was updated successfully, but these errors were encountered: