Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to G2C library version that supports CCSDS encoding #2759

Closed
8 of 21 tasks
JohnHalleyGotway opened this issue Dec 11, 2023 · 4 comments
Closed
8 of 21 tasks

Upgrade to G2C library version that supports CCSDS encoding #2759

JohnHalleyGotway opened this issue Dec 11, 2023 · 4 comments
Assignees
Labels
component: external dependency External dependency issue priority: high High Priority requestor: NOAA/EMC NOAA Environmental Modeling Center requestor: NOAA/GSL NOAA Global Systems Laboratory type: enhancement Improve something that it is currently doing
Milestone

Comments

@JohnHalleyGotway
Copy link
Collaborator

Describe the Enhancement

METplus Discussion dtcenter/METplus#2449 points out a segfault from MET when processing GRIB2 files from ECMWF encoded using the CCSDS encoding option. The problem lies not in MET itself, but in the GRIB2C Library (G2C) to which MET links.

As noted in this Discussion Comment pre-processing the GRIB2 files using the grib_set or wgrib2 utilities to change the encoding method provide a temporary workaround.

This issue is to monitor the progress on issue NOAA-EMC/NCEPLIBS-g2c#461 which is meant to fix the underlying problem in the GRIB2C library. When that issue is fixed and an updated version of the G2C library is released, update the MET compilation script as needed to begin using the new version of that library.

Consider recompiling the existing MET builds for MET version 11.1.0 and MET version 12.0.0 using the updated G2C library version, as needed.

Time Estimate

3 days?

Sub-Issues

Consider breaking the enhancement down into sub-issues.
None needed.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required: @jprestop
  • Select scientist(s) or no scientist required: None needed

Labels

  • Review default alert labels
  • Select component(s)
  • Select priority
  • Select requestor(s)

Milestone and Projects

  • Select Milestone as the next official version or Backlog of Development Ideas
  • For the next official version, select the MET-X.Y.Z Development project

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next official version
    Select: MET-X.Y.Z Development project for development toward the next official release
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added type: enhancement Improve something that it is currently doing requestor: NOAA/EMC NOAA Environmental Modeling Center requestor: NOAA/GSL NOAA Global Systems Laboratory alert: NEED ACCOUNT KEY Need to assign an account key to this issue component: external dependency External dependency issue priority: high High Priority labels Dec 11, 2023
@JohnHalleyGotway JohnHalleyGotway added this to the MET 12.0.0 milestone Dec 11, 2023
@JohnHalleyGotway JohnHalleyGotway moved this from 🔖 Ready to 🛑 Stalled in MET-12.0.0 Development May 15, 2024
@jprestop jprestop modified the milestones: MET-12.0.0, MET-12.1.0 Oct 4, 2024
@jprestop jprestop moved this from 🟢 Ready to 🚧 Stalled in MET-12.1.0 Development Oct 4, 2024
@jprestop jprestop moved this from 🚧 Stalled to 🟢 Ready in MET-12.1.0 Development Oct 4, 2024
@jprestop jprestop added the alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle label Oct 4, 2024
@jprestop
Copy link
Collaborator

jprestop commented Oct 4, 2024

@JohnHalleyGotway After moving this issue forward to 12.1.0, I looked into this issue further. The description of this issue includes:

This issue is to monitor the progress on issue NOAA-EMC/NCEPLIBS-g2c#461 which is meant to fix the underlying problem in the GRIB2C library. When that issue is fixed and an updated version of the G2C library is released, update the MET compilation script as needed to begin using the new version of that library.

Note that the referenced NCEPLIBS-g2c issue is currently closed, however, after reading through the comments, there were no changes made.

The developer suggests to the user that there "could be an incompatibility between g2c (built with MSVC++) and g2 (Intel Fortran) and your program (Intel Fortran) what does not show itself until program execution". And then indicated:

As of now there are no changes to g2c needed. The AEC compression is working correctly from within the g2c library. Changes are definitely needed in NCEPLIBS-g2, but we can perhaps discuss that in an issue for g2, likely in NOAA-EMC/NCEPLIBS-g2#705 or NOAA-EMC/NCEPLIBS-g2#458. IMO, this specific issue can be closed.

However, we are not using g2, but rather only g2c. I'm not sure where this leaves us. I don't have a full understanding of the underlying issue, but am wondering if you think we need to submit an issue to g2c for this problem?

@jprestop
Copy link
Collaborator

@mollybsmith-noaa Please see my comment above. It looks like no fix is coming for this issue. Please let us know if you have any concerns.

@mollybsmith-noaa
Copy link
Contributor

@jprestop The re-encoding via wgrib2 is an acceptable workaround, albeit clunky, so the fix is not vital at this point.

@jprestop
Copy link
Collaborator

@mollybsmith-noaa Thank you. I'm going to close this issue as "not planned". We can reopen it in the future if necessary.

@jprestop jprestop closed this as not planned Won't fix, can't repro, duplicate, stale Oct 10, 2024
@github-project-automation github-project-automation bot moved this from 🟢 Ready to 🏁 Done in MET-12.1.0 Development Oct 10, 2024
@JohnHalleyGotway JohnHalleyGotway removed alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: external dependency External dependency issue priority: high High Priority requestor: NOAA/EMC NOAA Environmental Modeling Center requestor: NOAA/GSL NOAA Global Systems Laboratory type: enhancement Improve something that it is currently doing
Projects
None yet
Development

No branches or pull requests

3 participants