Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance TC-DLand to use updated NHC land definition data #2751

Open
8 of 27 tasks
JohnHalleyGotway opened this issue Nov 29, 2023 · 3 comments
Open
8 of 27 tasks

Enhance TC-DLand to use updated NHC land definition data #2751

JohnHalleyGotway opened this issue Nov 29, 2023 · 3 comments
Assignees
Labels
MET: Tropical Cyclone Tools priority: blocker Blocker requestor: CSU/CIRA Colorado State University, Cooperative Institute for Research in the Atmosphere requestor: DTC/T&E General DTC Testing and Evaluation work type: enhancement Improve something that it is currently doing
Milestone

Comments

@JohnHalleyGotway
Copy link
Collaborator

JohnHalleyGotway commented Nov 29, 2023

Describe the Enhancement

MET Issue #2550 added this land definition file data/tc_data/v2023-04-07_gdland_table.dat. It is an ASCII representation of distance to land that is read by the TC-Diag Python code in scripts/python/tc_diag. This overlaps with the functionality provided by the TC-DLand tool.

The tasks for this issue include:

  • Check with @musgrave-kate in January 2024 to acquire update land definition files in use at NHC.
  • Replace the existing aland.dat, wland.dat, and shland.dat data files in the data/tc_data directory with the updated file(s).
  • Make any changes necessary in TC-DLand to use the updated datasets.
  • Carefully compare the distance to land values between v2023-04-07_gdland_table.dat and the newly generate TC-DLand output and address any differences.
  • Regenerate the existing dland_global_tenth_degree.nc and dland_nw_hem_tenth_degree.nc data files using the updated land data file.
  • Coordinate with @robertdemariacira to enhance the TC-Diag Python code to use the TC-DLand output rather than v2023-04-07_gdland_table.dat and remove v2023-04-07_gdland_table.dat from the repository.

Time Estimate

3 days?

Sub-Issues

Consider breaking the enhancement down into sub-issues.
None needed.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Charge NOAA R2O HAFS TnE (2784603)

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required:

Labels

  • Review default alert labels
  • Select component(s)
  • Select priority
  • Select requestor(s)

Milestone and Projects

  • Select Milestone as the next official version or Backlog of Development Ideas
  • For the next official version, select the MET-X.Y.Z Development project

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next official version
    Select: MET-X.Y.Z Development project for development toward the next official release
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added type: enhancement Improve something that it is currently doing MET: Tropical Cyclone Tools priority: high High Priority requestor: CSU/CIRA Colorado State University, Cooperative Institute for Research in the Atmosphere labels Nov 29, 2023
@JohnHalleyGotway JohnHalleyGotway added this to the MET 12.0.0 milestone Nov 29, 2023
@JohnHalleyGotway JohnHalleyGotway self-assigned this Nov 29, 2023
@jvigh
Copy link
Contributor

jvigh commented Jan 10, 2024

@JohnHalleyGotway JohnHalleyGotway added requestor: DTC/T&E General DTC Testing and Evaluation work priority: blocker Blocker and removed priority: high High Priority labels Jul 11, 2024
@JohnHalleyGotway
Copy link
Collaborator Author

As discussed with @KathrynNewman during the HAFS R2O meeting, this work can be done with that funding source and included in the MET-12.0.0 release. The issue has been updated to charge project 2784603.

While doing this, please also update the MET documentation to link to more information about the ATCF file format:
https://ftp.nhc.noaa.gov/atcf/README

And provide a more clear definition of the ADECK, BDECK, EDECK terminology used primarily at NOAA/NHC, as requested by @mkavulich.

@JohnHalleyGotway
Copy link
Collaborator Author

Discussed during the HAFS project meeting on Sept 3, 2024. Once @KathrynNewman locates/provides the updated land data file, @JohnHalleyGotway can update TC-DLand to process it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MET: Tropical Cyclone Tools priority: blocker Blocker requestor: CSU/CIRA Colorado State University, Cooperative Institute for Research in the Atmosphere requestor: DTC/T&E General DTC Testing and Evaluation work type: enhancement Improve something that it is currently doing
Projects
Status: 🟢 Ready
Development

No branches or pull requests

3 participants