Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Plot-Point-Obs to print a summary of the point observations processed #2738

Open
9 of 22 tasks
JohnHalleyGotway opened this issue Nov 15, 2023 · 0 comments
Open
9 of 22 tasks
Assignees
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle MET: PreProcessing Tools (Point) priority: low Low Priority requestor: Community General Community type: enhancement Improve something that it is currently doing

Comments

@JohnHalleyGotway
Copy link
Collaborator

Describe the Enhancement

This idea arose during the METplus Advanced Training Series on 11/15/23 when discussing Python embedding. When preparing Python scripts, users are advised to run plot_data_plane and plot_point_obs to validate their Python embedding scripts for gridded and point data, respectively.

Running plot_data_plane with -v 4 prints the following information about the grid and values being plotted:

DEBUG 4: Grid information:
DEBUG 4:    Projection: Lambert Conformal
DEBUG 4:    Nx: 185
DEBUG 4:    Ny: 129
DEBUG 4:    Lat_LL: 12.190
DEBUG 4:    Lon_LL: 133.459
DEBUG 4:    Lon_orient: 95.000
DEBUG 4:    Alpha: 406.820
DEBUG 4:    Cone: 0.423
DEBUG 4:    Bx: 104.0012
DEBUG 4:    By: 356.7313
DEBUG 4: 
DEBUG 4: Data plane information:
DEBUG 4:    plane min: 252
DEBUG 4:    plane max: 270
DEBUG 4:    valid time: 20050807_120000
DEBUG 4:    lead time: 120000
DEBUG 4:    init time: 20050807_000000
DEBUG 4:    accum time: 000000

However, running plot_point_obs with -v 4 only prints info about the lat/lon locations being plotted:

DEBUG 3: For point data group 1, plotting 2312 locations for 78376 observations.
DEBUG 4: [1] Plotting location [ lat, lon, val ] = [ 31.87, -106.7, -9999 ]
DEBUG 4: [2] Plotting location [ lat, lon, val ] = [ 31.94, -102.19, -9999 ]

This issue is to enhance plot_point_obs to log additional summary information about the point observations processed. Recommend printing a list of variable names, levels, values, and locations. Consult with @DanielAdriaansen to decide how to organize the summary info in a user-friendly way. This summary info could be printed at -v 3 or -v 4, at the discretion of @DanielAdriaansen.

Time Estimate

1 day

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Review default alert labels
  • Select component(s)
  • Select priority
  • Select requestor(s)

Milestone and Projects

  • Select Milestone as the next official version or Backlog of Development Ideas
  • For the next official version, select the MET-X.Y.Z Development project

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next official version
    Select: MET-X.Y.Z Development project for development toward the next official release
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added type: enhancement Improve something that it is currently doing priority: low Low Priority requestor: Community General Community MET: PreProcessing Tools (Point) labels Nov 15, 2023
@JohnHalleyGotway JohnHalleyGotway added this to the MET 12.0.0 milestone Nov 15, 2023
@JohnHalleyGotway JohnHalleyGotway changed the title Enhance Plot-Point-Obs to keep track of the point observations plotted and print a summary of them Enhance Plot-Point-Obs to print a summary of the point observations processed Nov 15, 2023
@JohnHalleyGotway JohnHalleyGotway added the alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle label Oct 3, 2024
@DanielAdriaansen DanielAdriaansen added the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle MET: PreProcessing Tools (Point) priority: low Low Priority requestor: Community General Community type: enhancement Improve something that it is currently doing
Projects
None yet
Development

No branches or pull requests

2 participants