Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split git-issue.sh into multiple files #55

Open
vyrondrosos opened this issue Jun 5, 2019 · 2 comments
Open

Split git-issue.sh into multiple files #55

vyrondrosos opened this issue Jun 5, 2019 · 2 comments

Comments

@vyrondrosos
Copy link
Collaborator

vyrondrosos commented Jun 5, 2019

With the main script file nearing 1200 lines of code --and my GSoC version at 1500-- and getting a bit unwieldy, I was considering splitting out some of the functions to a secondary source file(for example the ones concerning GitHub/GitLab import/export). Would that be OK, or would it be preferable to keep it to the single file, e.g for easier installation?

@dspinellis
Copy link
Owner

Good point! Some files would then need to be installed in a library folder (e.g. /usr/lib/git-issue. Is there precedent for this? Where are Git internal helper files located? How is then installation handled? Alternatively, the split could involve creating some internal helper binaries e.g. git-issue-import git-issue-export and install them as usual in a bin folder.

@vyrondrosos
Copy link
Collaborator Author

Those are some good points! It seems that git does install some library script files under /usr/lib/git-core, so I think that installing a /usr/lib/git-issue directory wouldn't be unprecedented. The 'separate executables for some subcommands' method is certainly interesting and could be useful but I believe there still would need to be a library file for them to source, since most commands currently rely on some common helper functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants