Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for yarn v2+ #496

Open
jagamypriera opened this issue Oct 19, 2023 · 6 comments · May be fixed by #506 or #507
Open

Add support for yarn v2+ #496

jagamypriera opened this issue Oct 19, 2023 · 6 comments · May be fixed by #506 or #507

Comments

@jagamypriera
Copy link

While yarn v2 has a built-in patch feature, but it involves a lengthy process. To be honest, patch-package is much easier and more convenient to use. Please consider supporting Yarn v2+.
@JounQin
Copy link

JounQin commented Oct 20, 2023

+1 for this, the patch experience of yarn 2+ is bad as pnpm, I love patch-package's solution.

@noahm
Copy link

noahm commented Nov 9, 2023

I agree, patch-package has a much better UX and I prefer using it over yarn's native patches by far. To that end, I already have mostly working support for yarn 2+ in a fork and I hope to eventually get it into shape for a PR here.

@JounQin
Copy link

JounQin commented Dec 19, 2023

I already have mostly working support for yarn 2+ in a fork and I hope to eventually get it into shape for a PR here.

@noahm Would you like to share it? Or just raise it as a PR?

@noahm noahm linked a pull request Dec 20, 2023 that will close this issue
Open
@noahm
Copy link

noahm commented Dec 20, 2023

@JounQin Thanks for reminding me! I just opened #506 with my changes. I wouldn't personally consider it ready to merge until new integration tests were added with more recent yarn versions, but I don't have time to keep working on it for a while. If anybody else wants to help along those lines, it would be appreciated!

JounQin added a commit to un-ts/patch-package that referenced this issue Dec 21, 2023
@JounQin
feat: support yarn v2+ w/wo corepack enabled
1fcf733 
fix ds300#272
fix ds300#496
close ds300#506
@JounQin JounQin linked a pull request Dec 21, 2023 that will close this issue
Open
@JounQin
Copy link

JounQin commented Dec 21, 2023

I raised a new PR #507 to fix all my known issues.

JounQin added a commit to un-ts/patch-package that referenced this issue Dec 21, 2023
@JounQin
feat: support yarn v2+ w/wo corepack enabled
ae90c02 
fix ds300#272
fix ds300#496
close ds300#506
@JounQin
Copy link

JounQin commented Jan 6, 2024

I've just publish my PR #507 as @unts/patch-package, you can give it a try.

jdalton pushed a commit to jdalton/patch-package that referenced this issue Jun 18, 2024
@JounQin @jdalton
feat: support yarn v2+ w/wo corepack enabled
54218fe 
fix ds300#272
fix ds300#496
close ds300#506
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@noahm @jagamypriera @JounQin