Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isotp-c integration (updates) #26

Open
SimonCahill opened this issue Feb 23, 2024 · 4 comments
Open

isotp-c integration (updates) #26

SimonCahill opened this issue Feb 23, 2024 · 4 comments

Comments

@SimonCahill
Copy link

Hi there!

A while ago you integrated my fork of the isotp-c library in this project.
I just wanted to inform you that several updates have been published since, and I thought it would be good to inform you.

The latest version is v1.1.1.

@driftregion
Copy link
Owner

Thanks Simon for this notification. I appreciate your work.
I'm still running a fork with a modified isotp_user_send_can that accepts an additional void * so that multiple CAN interfaces may be used by one binary. Is this something you'd consider upstreaming?

@SimonCahill
Copy link
Author

Sounds like a good feature!

To maintain backward-compat. could you add this as an option in the Makefile and CMakeLists?
That way this feature could be enabled at compile-time.

Shoot me a PR and I'll see it gets merged :)

@driftregion
Copy link
Owner

Sounds good. Next time I touch isotp-c I'll send a PR. It might be a while though. The library never has any problems. ;)

@SimonCahill
Copy link
Author

No worries, I'm looking forward to the contribution!
Take your time, it's no rush

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants