Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draper still actively maintained? #921

Open
Idletime-studios opened this issue Nov 30, 2022 · 17 comments
Open

Draper still actively maintained? #921

Idletime-studios opened this issue Nov 30, 2022 · 17 comments

Comments

@Idletime-studios
Copy link

Hello,

I was wondering if the draper gem is still actively maintained, it looks like there was an update 12 months ago.

So not sure.

@ajsharp
Copy link

ajsharp commented Jun 7, 2023

@codebycliff or someone who has commit on this repo -- can you either mark this repo as inactive, find a new maintainer, or redirect people to an active fork? Thank you.

@y-yagi
Copy link
Collaborator

y-yagi commented Jun 12, 2023

@codebycliff
If you are still maintaining this project, could you confirm this issue? 🙏

If not, I would like to confirm how to maintain this gem.

@spuyet
Copy link

spuyet commented Jan 12, 2024

ping @codebycliff 😄

@mpkhr
Copy link

mpkhr commented Jan 29, 2024

+1

@Alexander-Senko
Copy link
Collaborator

@jcasimir, @steveklabnik? 🤔

@steveklabnik
Copy link
Member

I have not even written real Ruby code in pretty much a decade at this point, so sorry! I don't know who is currently maintaining draper.

@Alexander-Senko
Copy link
Collaborator

Alexander-Senko commented Feb 12, 2024

@nashby, @haines, @seanlinsley — could it be possible that you know someone with an access to the repository? 🙏

@Alexander-Senko
Copy link
Collaborator

I could try myself as a maintainer if possible.

@seanlinsley
Copy link
Member

I'd be happy to help onboard a new maintainer, but I only have access to the github repo. @jcasimir and @codebycliff are the only ones with rubygems access currently.

@Alexander-Senko
Copy link
Collaborator

I'd be happy to help onboard a new maintainer, but I only have access to the github repo. @jcasimir and @codebycliff are the only ones with rubygems access currently.

@seanlinsley, sounds great! GitHub is enough to start, I guess. We've got a lot to do here before releasing a thing.

@y-yagi
Copy link
Collaborator

y-yagi commented Aug 20, 2024

@seanlinsley
Could you give me permission to access the GitHub repository? I would like to maintain CI first.

@seanlinsley
Copy link
Member

Sorry for the delay, @Alexander-Senko and @y-yagi I've given you both write access to the GitHub repo.

@Alexander-Senko
Copy link
Collaborator

Alexander-Senko commented Dec 11, 2024

Greetings,

I hope someone is still interested in what’s going on with Draper.

I’ve already shared my thoughts on its further development while replying to some issues. It would be great to start a discussion sharing them here too.

At first, I was eager to develop Draper and bring it back to life, but I don’t see it viable for now. The reasons are:

  1. Me and @y-yagi, being the only active maintainers for now, don’t have access to RubyGems.org to publish new releases. That’s why the last one was published as a Git branch.

  2. I consider refactoring Draper a better way than fixing a ton of bugs here and their, caused by it’s architecture. The new version would unlikely be fully backwards compatible and would require a major release.

  3. Every PR requires a code review. It’s OK for the small ones, but we need more active maintainers to review and discuss that big ones.

That’s why I came to rewriting Draper from scratch on my own and splitting it into several libs:

  1. SimpleDelegator from the standard library is the base.
  2. Magic Lookup for the generic class inference.
  3. Magic Decorator for generic decorators.
  4. Magic Presenter for Rails presenters / view models.

They do virtually all the Draper does and more.

@seanlinsley
Copy link
Member

I was recently granted access to the gem on rubygems.org so we could still revive Draper, but as you point out there are good reasons to prefer a ground-up rewrite. Whichever direction we choose, thank you @Alexander-Senko for putting so much time into this.

@Alexander-Senko
Copy link
Collaborator

Alexander-Senko commented Dec 11, 2024

@seanlinsley, that’s great! Let’s release v4.0.3 then. It’s ready for gem build.

@y-yagi
Copy link
Collaborator

y-yagi commented Dec 11, 2024

@Alexander-Senko
We have introduced some breaking changes like #928. So updating the patch version isn't appropriate. I think we should consider updating a minor or major version.

@Alexander-Senko
Copy link
Collaborator

@y-yagi, I still don’t consider #928 a breaking change, but anyway, I’ve agreed with you back then to not include it into v4.0.3.

v4.0.3 is really a bug-fix release. Please read the release notes if still in doubt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants