fix: Protect BumpUp() from running in parallel to serialization
#4307
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
reviewed
Dec 13, 2024
| @@ -468,6 +468,7 @@ OpResult<DbSlice::PrimeItAndExp> DbSlice::FindInternal(const Context& cntx, std: | |||
| db.prime.CVCUponBump(change_cb_.back().first, res.it, bump_cb); | |||
| } | |||
|
|
|||
| block_counter_.Wait(); // We must not change the bucket's internal order during serialization | |||
There was a problem hiding this comment.
not related to this PR but block_counter_ is not a good name because it does not say much about the semantics of the variable.
kostasrim
approved these changes
Dec 13, 2024
| @@ -468,6 +468,7 @@ OpResult<DbSlice::PrimeItAndExp> DbSlice::FindInternal(const Context& cntx, std: | |||
| db.prime.CVCUponBump(change_cb_.back().first, res.it, bump_cb); | |||
| } | |||
|
|
|||
| block_counter_.Wait(); // We must not change the bucket's internal order during serialization | |||
There was a problem hiding this comment.
I would have to moved it to line 463 such that the whole block (including the capture version change) is atomic but it should be fine this way as well
There was a problem hiding this comment.
I am merging this because I want the tests to run with this flag over the weekend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4306