Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: circular dependency in qlist #4302

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: circular dependency in qlist #4302

wants to merge 2 commits into from
+20 −7

Conversation

romange
Copy link
Collaborator

@romange romange commented Dec 12, 2024

fixes #4294

@romange romange requested a review from kostasrim December 12, 2024 13:00
@romange
fix: circular dependency in qlist
2202871 
fixes #4294

Signed-off-by: Roman Gershman <[email protected]>
adiholden
adiholden previously approved these changes Dec 12, 2024
View reviewed changes
kostasrim
kostasrim previously approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@kostasrim kostasrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@adiholden
Copy link
Collaborator

please also change this function pass is_huge to randstr_sequence in this function which were this bug was discovered
b37287b#diff-35fc27c757d9b3830899712b367143f5c61f801b8f252b7bfa6e59bfbde6da49R57
function LG_funcs.add_list(key, keys)
local is_huge = keys[key]
--- TODO -- investigate why second case of replication_test_all fails
--- we somehow create a quicklist that is circular and we deadlock
redis.apcall('LPUSH', key, unpack(randstr_sequence(false)))
end

@romange romange dismissed stale reviews from kostasrim and adiholden via 67aaaaf December 12, 2024 15:47
@romange
chore: fixes
dd6c7ca 
Signed-off-by: Roman Gershman <[email protected]>
@romange romange requested a review from kostasrim December 13, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adiholden adiholden adiholden left review comments

@kostasrim kostasrim Awaiting requested review from kostasrim

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

circular dependency in quicklist nodes causes deadlock
3 participants
@romange @adiholden @kostasrim