feat: add migration_finalization_timeout_ms flag #4301
+9
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adiholden
reviewed
Dec 12, 2024
BorysTheDev
force-pushed
the
MigrationFinalizationTImeout_flag
branch
from
dc95056 to
60e7def
Compare
kostasrim
reviewed
Dec 13, 2024
| @@ -20,7 +20,10 @@ | |||
| #include "server/server_family.h" | |||
| #include "util/fibers/synchronization.h" | |||
|
|
|||
| ABSL_FLAG(int, slot_migration_connection_timeout_ms, 5000, "Timeout for network operations"); | |||
| ABSL_FLAG(int, slot_migration_connection_timeout_ms, 2000, | |||
There was a problem hiding this comment.
Have you synced with @romange about the new flag? I am asking cause we usually discuss before we introduce a new flag
There was a problem hiding this comment.
we have discussed it with @adiholden
Comment on lines
+24
to
+26
| "Connection creating timeout for migration operations"); | ||
| ABSL_FLAG(int, migration_finalization_timeout_ms, 30000, | ||
| "Timeout for migration finalization operation"); |
There was a problem hiding this comment.
Can we add a little bit more in the description about what these flags do because Connection creating timeout for migration operations seems vague. I would expect with that description a timeout would trigger at 2000 ms which would include the 30000 ms for the migration to finalize
There was a problem hiding this comment.
I don't know what else should be added. migration finalization is a several-step algorithm and it needs time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #4299
we decided to distinguish connection and finalization timeouts and introduced the new flag